Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change categories in AWS package #1357

Merged
merged 3 commits into from Jul 27, 2021
Merged

Change categories in AWS package #1357

merged 3 commits into from Jul 27, 2021

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 26, 2021

What does this PR do?

This PR is to remove network and security categories at the package level for AWS and add them into each policy template.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@kaiyan-sheng kaiyan-sheng self-assigned this Jul 26, 2021
@elasticmachine
Copy link

elasticmachine commented Jul 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-27T21:20:49.710+0000

  • Duration: 17 min 35 sec

  • Commit: 5cb8a73

Test stats 🧪

Test Results
Failed 0
Passed 247
Skipped 0
Total 247

Trends 🧪

Image of Build Times

Image of Tests

@leehinman
Copy link
Contributor

I think we want security category on:

  • cloudtrail
  • s3
  • vpcflow

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit AWS categories
3 participants