[oracle_weblogic] Add Integration Package with ThreadPool Data Stream #3189

kush-elastic · 2022-04-25T16:16:12Z

Enhancement

What does this PR do?

Generated the skeleton of Oracle WebLogic integration package.
Added 1 data stream (ThreadPool).
Added data collection logic for the data streams.
Added the ingest pipeline for the data streams.
Mapped fields according to the ECS schema and added Fields metadata in the appropriate yaml files.
Added dashboards and visualizations.
Added system test cases for the data stream.

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install elastic-package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/oracle_weblogic directory.
Run the following command to run tests.
elastic-package test

Related issues

Screenshots

elasticmachine · 2022-04-25T16:29:04Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-06-06T04:59:26.883+0000
Duration: 24 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	45
Skipped	0
Total	45

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-04-29T16:34:40Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`4/4`)	💚
Files	100.0% (`4/4`)	💚 3.497
Classes	100.0% (`4/4`)	💚 3.497
Methods	100.0% (`41/41`)	💚 10.623
Lines	100.0% (`239/239`)	💚 9.209
Conditionals	100.0% (`0/0`)	💚

yug-rajani

Requested some changes

packages/oracle_weblogic/_dev/build/docs/README.md

packages/oracle_weblogic/data_stream/threadpool/elasticsearch/ingest_pipeline/default.yml

yug-rajani

LGTM!

agithomas · 2022-06-02T06:17:14Z

packages/oracle_weblogic/_dev/build/docs/README.md

+    User needs to [download](https://jolokia.org/download.html) and add the JAR file and set environment variables for Jolokia.
+
+    ```
+     -javaagent:/home/oracle/jolokia-jvm-1.6.0-agent.jar=port=<Port>,host=<hostname>


You can include jolokia-jvm-1.6.0-agent.jar as an example. The phrase 'jolokia-jvm-1.6.0-agent.jar' gives a wrong impression of mandatory dependency. Please change it to a generate format with jolokia-jvm-1.6.0-agent.jar mentioned as an example

agithomas · 2022-06-02T06:18:06Z

packages/oracle_weblogic/_dev/build/docs/README.md

+
+In order to ingest data from Oracle WebLogic:
+- You must know the host for Oracle WebLogic application, add that host while configuring the integration package.
+- Add default path for Jolokia.


Please elaborate default path to...?

agithomas · 2022-06-02T06:20:11Z

packages/oracle_weblogic/_dev/build/docs/README.md

+## Requirements
+
+In order to ingest data from Oracle WebLogic:
+- You must know the host for Oracle WebLogic application, add that host while configuring the integration package.


This is not a minimum requirement. It is a knowledge a user may need to have for configuring.

agithomas · 2022-06-02T07:55:30Z

packages/oracle_weblogic/data_stream/threadpool/fields/fields.yml

+              description: Number of stuck threads in the thread pool.
+            - name: total
+              type: long
+              description: Current number of live daemon and non-daemon threads.


It is a very tricky statement used in the documentation.

https://docs.oracle.com/cd/E17802_01/j2se/j2se/1.5.0/jcp/beta1/apidiffs/java/lang/management/ThreadMBean.html#getThreadCount()

It says 'including both both daemon and non-daemon threads'. The next line says : Return : the current number of live threads."

So, can there be any live threads that is not ( live daemon or non-deamon threads )?

If not sure, best is to change the description as either "Number of live threads" or "number of live threads including both daemon and non-daemon threads"

If the first option is selected, please change the singlestat panel title as "Live threads"

You may need to update below files

the

packages/oracle_weblogic/img/oracle_weblogic-threadpool.png packages/oracle_weblogic/kibana/lens/oracle_weblogic-c31dabf0-c132-11ec-aaae-35e5cf8554e6.json

agithomas · 2022-06-02T09:26:04Z

packages/oracle_weblogic/kibana/lens/oracle_weblogic-c31dabf0-c132-11ec-aaae-35e5cf8554e6.json

+                "layerType": "data"
+            }
+        },
+        "title": "Live Daemon and Non-Daemon Threads [Metrics Oracle WebLogic]",


Please refer to the previous comment

agithomas

Looks good to me

kush-elastic added 2 commits April 25, 2022 21:34

Add Integration Package with ThreadPool Data stream

a665bb1

Update CODEOWNERS and changelog.yml

3cc7023

kush-elastic added the Integration:oracle_weblogic label Apr 25, 2022

This was referenced Apr 26, 2022

[oracle_weblogic] Add Integration Package with Deployed Application Data Stream #3121

Merged

[oracle_weblogic] Add Integration Package with Admin Server Logs Data Stream #3066

Merged

kush-elastic changed the title ~~Add Integration Package with ThreadPool Data stream~~ [oracle_weblogic] Add Integration Package with ThreadPool Data stream Apr 26, 2022

kush-elastic changed the title ~~[oracle_weblogic] Add Integration Package with ThreadPool Data stream~~ [oracle_weblogic] Add Integration Package with ThreadPool Data Stream Apr 26, 2022

This was referenced Apr 26, 2022

[oracle_weblogic] Add Integration Package with Access Logs Data Stream #3068

Merged

[oracle_weblogic] Add Integration Package with Domain Logs Data Stream #3069

Merged

andrewkroh added Team:Service-Integrations Label for the Service Integrations team New Integration labels Apr 27, 2022

This was referenced Apr 29, 2022

[oracle_weblogic] Add Integration Package with Connections Data Stream #3234

Closed

[oracle_weblogic] Add Integration Package with Managed Server Logs Data Stream #3067

Merged

kush-elastic added the enhancement New feature or request label May 3, 2022

NITS

12d9105

kush-elastic mentioned this pull request May 5, 2022

[oracle_weblogic] Add Integration Package with Console Datastream #3281

Closed

4 tasks

kush-elastic added 3 commits May 18, 2022 12:18

Update system test

89e631b

Resolve merge conflicts

6b41d91

Minor changes in script

7c6c549

kush-elastic marked this pull request as ready for review May 30, 2022 07:10

kush-elastic requested a review from a team as a code owner May 30, 2022 07:10

kush-elastic requested review from mtojek, yug-rajani and agithomas May 30, 2022 07:12

yug-rajani suggested changes May 30, 2022

View reviewed changes

Minor nits

a43f452

kush-elastic requested a review from yug-rajani May 30, 2022 08:53

yug-rajani approved these changes May 30, 2022

View reviewed changes

agithomas reviewed Jun 2, 2022

View reviewed changes

Address review comments

1168df4

kush-elastic requested a review from agithomas June 2, 2022 11:54

Minor changes in visualization

5789afc

agithomas approved these changes Jun 6, 2022

View reviewed changes

yug-rajani merged commit e9b93a1 into elastic:main Jun 6, 2022

yug-rajani linked an issue Jun 7, 2022 that may be closed by this pull request

Oracle Weblogic Integration #2823

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[oracle_weblogic] Add Integration Package with ThreadPool Data Stream #3189

[oracle_weblogic] Add Integration Package with ThreadPool Data Stream #3189

kush-elastic commented Apr 25, 2022 •

edited

elasticmachine commented Apr 25, 2022 •

edited

Build stats

Test stats 🧪

elasticmachine commented Apr 29, 2022 •

edited

yug-rajani left a comment

yug-rajani left a comment

agithomas Jun 2, 2022

agithomas Jun 2, 2022

agithomas Jun 2, 2022

agithomas Jun 2, 2022

agithomas Jun 2, 2022

agithomas Jun 6, 2022

agithomas Jun 2, 2022

agithomas left a comment

[oracle_weblogic] Add Integration Package with ThreadPool Data Stream #3189

[oracle_weblogic] Add Integration Package with ThreadPool Data Stream #3189

Conversation

kush-elastic commented Apr 25, 2022 • edited

What does this PR do?

Checklist

How to test this PR locally

Related issues

Screenshots

elasticmachine commented Apr 25, 2022 • edited

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Apr 29, 2022 • edited

🌐 Coverage report

yug-rajani left a comment

Choose a reason for hiding this comment

yug-rajani left a comment

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas Jun 6, 2022

Choose a reason for hiding this comment

agithomas Jun 2, 2022

Choose a reason for hiding this comment

agithomas left a comment

Choose a reason for hiding this comment

kush-elastic commented Apr 25, 2022 •

edited

elasticmachine commented Apr 25, 2022 •

edited

elasticmachine commented Apr 29, 2022 •

edited