Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom processors and logs to log integration #4568

Conversation

fearful-symmetry
Copy link
Contributor

Closes #3432

What does this PR do?

This adds a field for custom tags and processors in the logs integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link

elasticmachine commented Nov 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-07T18:37:38.603+0000

  • Duration: 13 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 5, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.29
Classes 100.0% (0/0) 💚 2.29
Methods 33.333% (1/3) 👎 -58.202
Lines 100.0% (0/0) 💚 8.539
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One suggestion for consistency with other custom integrations.

packages/log/data_stream/log/manifest.yml Show resolved Hide resolved
Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
@fearful-symmetry fearful-symmetry merged commit 5e23ff0 into elastic:main Nov 7, 2022
changes:
- description: Add custom logs and processors
type: enhancement
link: https://github.com/elastic/integrations/pull/2538

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Idk if this is the place to mention, but the link here is for the past 1.0.0 release instead of the 1.1.0 one which is this one #4568.
This duplicates the link to the PR and is confusing in the official https://docs.elastic.co/integrations/log documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Log Integration] Add tags & processors to Custom Log datastreams
4 participants