Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Migrate EBS dashboard visualizations to lenses #5212

Merged
merged 3 commits into from Feb 15, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Feb 8, 2023

What does this PR do?

Migrates EBS visualizations to lenses.

Before:

ebs_before

After:

ebs_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Feb 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-13T12:21:57.700+0000

  • Duration: 50 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -13.869
Lines 85.925% (7387/8597) 👎 -3.205
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review February 9, 2023 09:51
@gpop63 gpop63 requested review from a team as code owners February 9, 2023 09:51
@tommyers-elastic
Copy link
Contributor

looks good! are the region and volume id drop down filters using the deprecated input control panels though?

thanks

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. As has been mentioned, we should take this opportunity to migrate the deprecated "controls visualizations" to the native dashboard controls (doc).

@gpop63
Copy link
Contributor Author

gpop63 commented Feb 13, 2023

I added the control groups and fixed first 2 panels width and position:

updated_ebs

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks gabriel!

@gpop63 gpop63 merged commit 5fca8c0 into elastic:main Feb 15, 2023
@elasticmachine
Copy link

Package aws - 1.32.0 containing this change is available at https://epr.elastic.co/search?package=aws

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
* add lenses

* add changelog entry and bump package version

* add control groups and fix dashboards width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants