Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ GCP ] Fix convert processor in Audit Pipeline #5597

Merged
merged 2 commits into from Mar 20, 2023

Conversation

leandrojmp
Copy link
Contributor

What does this PR do?

The Audit ingest pipeline has a convert processor that was breaking because the value of the field json.protoPayload.requestMetadata.callerIp is a string that was not being considered in the conditional.

This PR adds a new check in the conditional of the convert processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@leandrojmp leandrojmp requested review from a team as code owners March 20, 2023 21:06
@elasticmachine
Copy link

elasticmachine commented Mar 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T23:34:19.972+0000

  • Duration: 18 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@leandrojmp
Copy link
Contributor Author

Hello @efd6 , can you add the correct labels in this PR? Thanks!

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Mar 20, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 90.291% (93/103) 👍 23.281
Lines 96.0% (1464/1525) 👎 -2.797
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 8a6b1af into elastic:main Mar 20, 2023
3 checks passed
@elasticmachine
Copy link

Package gcp - 2.17.2 containing this change is available at https://epr.elastic.co/search?package=gcp

@leandrojmp leandrojmp deleted the fix_gcp_audit_ip_convert branch May 22, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:GCP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Audit Logs Integration v2.14.0 - Ingest Pipeline fails
3 participants