From 018313d66ad8422aeccc8e3063aef3862eafbffb Mon Sep 17 00:00:00 2001 From: Yuliia Naumenko Date: Sun, 29 Aug 2021 20:28:59 -0700 Subject: [PATCH] fixed merge --- x-pack/plugins/alerting/server/saved_objects/index.ts | 3 ++- .../alerting/server/saved_objects/migrations.test.ts | 9 ++------- .../plugins/alerting/server/saved_objects/migrations.ts | 7 +++++++ 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/alerting/server/saved_objects/index.ts b/x-pack/plugins/alerting/server/saved_objects/index.ts index b1d56a364a3dd4..f1afba147a2f7c 100644 --- a/x-pack/plugins/alerting/server/saved_objects/index.ts +++ b/x-pack/plugins/alerting/server/saved_objects/index.ts @@ -53,7 +53,8 @@ export function setupSavedObjects( savedObjects.registerType({ name: 'alert', hidden: true, - namespaceType: 'single', + namespaceType: 'multiple-isolated', + convertToMultiNamespaceTypeVersion: '8.0.0', migrations: getMigrations(encryptedSavedObjects, isPreconfigured), mappings: mappings.alert as SavedObjectsTypeMappingDefinition, management: { diff --git a/x-pack/plugins/alerting/server/saved_objects/migrations.test.ts b/x-pack/plugins/alerting/server/saved_objects/migrations.test.ts index 1fe71030c6e68b..5e850ad3226f80 100644 --- a/x-pack/plugins/alerting/server/saved_objects/migrations.test.ts +++ b/x-pack/plugins/alerting/server/saved_objects/migrations.test.ts @@ -1703,14 +1703,9 @@ describe('successful migrations', () => { describe('8.0.0', () => { test('no op migration for rules SO', () => { - const migration800 = getMigrations(encryptedSavedObjectsSetup)['8.0.0']; + const migration800 = getMigrations(encryptedSavedObjectsSetup, isPreconfigured)['8.0.0']; const alert = getMockData({}, true); - expect(migration800(alert, migrationContext)).toEqual({ - ...alert, - attributes: { - ...alert.attributes, - }, - }); + expect(migration800(alert, migrationContext)).toEqual(alert); }); }); }); diff --git a/x-pack/plugins/alerting/server/saved_objects/migrations.ts b/x-pack/plugins/alerting/server/saved_objects/migrations.ts index c0af554cd7a44b..287636c69bb751 100644 --- a/x-pack/plugins/alerting/server/saved_objects/migrations.ts +++ b/x-pack/plugins/alerting/server/saved_objects/migrations.ts @@ -106,6 +106,12 @@ export function getMigrations( pipeMigrations(setLegacyId, getRemovePreconfiguredConnectorsFromReferencesFn(isPreconfigured)) ); + const migrationRules800 = createEsoMigration( + encryptedSavedObjects, + (doc: SavedObjectUnsanitizedDoc): doc is SavedObjectUnsanitizedDoc => true, + (doc) => doc // no-op + ); + return { '7.10.0': executeMigrationWithErrorHandling(migrationWhenRBACWasIntroduced, '7.10.0'), '7.11.0': executeMigrationWithErrorHandling(migrationAlertUpdatedAtAndNotifyWhen, '7.11.0'), @@ -114,6 +120,7 @@ export function getMigrations( '7.14.1': executeMigrationWithErrorHandling(migrationSecurityRules714, '7.14.1'), '7.15.0': executeMigrationWithErrorHandling(migrationSecurityRules715, '7.15.0'), '7.16.0': executeMigrationWithErrorHandling(migrateRules716, '7.16.0'), + '8.0.0': executeMigrationWithErrorHandling(migrationRules800, '8.0.0'), }; }