From 2764554720352ea20b6f7f0763feec3b7b8dd88d Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Mon, 20 Apr 2020 20:19:09 +0100 Subject: [PATCH] fix(NA): test run with lodash has --- .../server/lib/telemetry/usage_collector.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts b/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts index 142ff00e49600a..ad8a1d7b573ced 100644 --- a/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts +++ b/x-pack/plugins/upgrade_assistant/server/lib/telemetry/usage_collector.ts @@ -4,7 +4,7 @@ * you may not use this file except in compliance with the Elastic License. */ -import { set } from 'lodash'; +import { has, set } from 'lodash'; import { APICaller, ElasticsearchServiceStart, @@ -85,11 +85,8 @@ export async function fetchUpgradeAssistantMetrics( } const telemetryObj = defaultTelemetrySavedObject; - Object.keys(defaultTelemetrySavedObject).forEach((key: string) => { - if ( - !upgradeAssistantTelemetrySavedObjectAttrs.hasOwnProperty(key) || - !upgradeAssistantTelemetrySavedObjectAttrs[key] - ) { + Object.keys(upgradeAssistantTelemetrySavedObjectAttrs).forEach((key: string) => { + if (!has(defaultTelemetrySavedObject, key)) { return; }