From 2f269f8cd080b49c44aa42a25605d290414577cb Mon Sep 17 00:00:00 2001 From: Martin Hickey Date: Wed, 1 Mar 2017 17:15:04 +0000 Subject: [PATCH] Update document after new changes for js and info string translations --- .../development-internationalization.asciidoc | 47 ++++++++++++++++--- 1 file changed, 40 insertions(+), 7 deletions(-) diff --git a/docs/development/plugin/development-internationalization.asciidoc b/docs/development/plugin/development-internationalization.asciidoc index 4cc305cf853b2d..25501878288386 100644 --- a/docs/development/plugin/development-internationalization.asciidoc +++ b/docs/development/plugin/development-internationalization.asciidoc @@ -103,10 +103,12 @@ Before `_create.html` -------------------------------------------------------------------------- +-----------------------------------------------------------------------------------------------------

Configure an index pattern

In order to use Kibana you must configure at least one index pattern… -------------------------------------------------------------------------- + + +----------------------------------------------------------------------------------------------------- [[after]] After @@ -114,19 +116,50 @@ After `_create.html` --------------------------------------------------------- +-------------------------------------------------------------------------------------------

--------------------------------------------------------- + + +------------------------------------------------------------------------------------------- + +* In the view (JS) file, such as +`src/core_plugins/kibana/public/management/sections/indices/_create.js` +As above, replace English text with translation keys, and copy the English text +into the `en.json` file appropriately. Note that some strings may not be user facing +and do not need to be replaced then. Also note the prefix `KIBANA-` matching the plugin +being translated. + +[[before]] +Before +++++++ + +`_create.js` + +-------------------------------------------------------------------------------------------------------------- + notify.error('Could not locate any indices matching that pattern. Please add the index to Elasticsearch'); +-------------------------------------------------------------------------------------------------------------- + +[[after]] +After ++++++ + +`_create.js` + +------------------------------------------------------------------------------------------- + notify.error($translate.instant('KIBANA-NO_INDICES_MATCHING_PATTERN')); +------------------------------------------------------------------------------------------- `en.json` --------------------------------------------------------------------------------- +----------------------------------------------------------------------------------------------------------------------------------------- { "KIBANA-CONFIGURE_INDEX_PATTERN": "Configure an index pattern", - "KIBANA-MUST_CONFIGURE_INDEX_PATTERN": "In order to use Kibana you must…" + "KIBANA-MUST_CONFIGURE_INDEX_PATTERN": "In order to use Kibana you must…", + "KIBANA-FIELD_FILTER_EVENTS_GLOBAL_TIME" : "This field will be used to filter events with the global time filter", + "KIBANA-NO_INDICES_MATCHING_PATTERN": "Could not locate any indices matching that pattern. Please add the index to Elasticsearch", } --------------------------------------------------------------------------------- +----------------------------------------------------------------------------------------------------------------------------------------- * Refresh the Kibana page and verify the UI looks the same. * Refer to Kibana core plugin (`src/core_plugins/kibana/`) for examples.