From 372b79e8162987d405b05dd181be5a1a116ed7be Mon Sep 17 00:00:00 2001 From: Tyler Smalley Date: Mon, 12 Aug 2019 08:29:00 -0700 Subject: [PATCH] Disables response logging as a default (#42353) Previously, if any of the following were true, we would log HTTP responses. - `logging.json` was set - `logging.dest` was set - `TTY` was detected The logging format should not dictate what is logged Signed-off-by: Tyler Smalley --- docs/migration/migrate_8_0.asciidoc | 6 ++++++ src/legacy/server/logging/configuration.js | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/migration/migrate_8_0.asciidoc b/docs/migration/migrate_8_0.asciidoc index e833911fab2dd8..43bfec5252ebab 100644 --- a/docs/migration/migrate_8_0.asciidoc +++ b/docs/migration/migrate_8_0.asciidoc @@ -48,6 +48,12 @@ for example, `logstash-*`. *Impact:* To restore the previous behavior, in kibana.yml set `logging.timezone: UTC`. +[float] +==== Responses are never logged by default +*Details:* Previously responses would be logged if either `logging.json` was true, `logging.dest` was specified, or a `TTY` was detected. + +*Impact:* To restore the previous behavior, in kibana.yml set `logging.events.response=*`. + [float] ==== `xpack.security.authProviders` is no longer valid *Details:* The deprecated `xpack.security.authProviders` setting in the `kibana.yml` file has been removed. diff --git a/src/legacy/server/logging/configuration.js b/src/legacy/server/logging/configuration.js index 44b128f5846712..6a58694a247eac 100644 --- a/src/legacy/server/logging/configuration.js +++ b/src/legacy/server/logging/configuration.js @@ -45,7 +45,6 @@ export default function loggingConfiguration(config) { else { _.defaults(events, { log: ['info', 'warning', 'error', 'fatal'], - response: config.get('logging.json') ? '*' : '!', request: ['info', 'warning', 'error', 'fatal'], error: '*' });