From 3a43db785d72d7a0e470955fb5ee5491288a0795 Mon Sep 17 00:00:00 2001 From: kevinlog Date: Thu, 26 Dec 2019 15:30:22 -0500 Subject: [PATCH] linting --- .../public/applications/endpoint/index.tsx | 35 ++++++++++++------- .../feature_controls/endpoint_spaces.ts | 16 ++++----- 2 files changed, 29 insertions(+), 22 deletions(-) diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/index.tsx b/x-pack/plugins/endpoint/public/applications/endpoint/index.tsx index 80a2d5428070d2..51a2074e4da822 100644 --- a/x-pack/plugins/endpoint/public/applications/endpoint/index.tsx +++ b/x-pack/plugins/endpoint/public/applications/endpoint/index.tsx @@ -17,9 +17,9 @@ import { Route, Router, Switch } from 'react-router-dom'; export function renderApp(coreStart: CoreStart, { appBasePath, element }: AppMountParameters) { coreStart.http.get('/api/endpoint/hello-world'); - const history = createHashHistory() - //const history = createBrowserHistory({ basename: appBasePath }) - ReactDOM.render(, element); + const history = createHashHistory(); + // const history = createBrowserHistory({ basename: appBasePath }) + ReactDOM.render(, element); return () => { ReactDOM.unmountComponentAtNode(element); @@ -30,22 +30,33 @@ interface RouterProps { history: History; } -const AppRoot: React.FC = React.memo(({history}) => ( +const AppRoot: React.FC = React.memo(({ history }) => ( - - - ( + + + (

- )} /> - ( + )} + /> + (

- )} /> - } /> -
+ )} + /> + ( + + )} + /> +
)); diff --git a/x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts b/x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts index 72b994bc318ec0..7b7eefea781a17 100644 --- a/x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts +++ b/x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts @@ -12,7 +12,7 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { const testSubjects = getService('testSubjects'); const appsMenu = getService('appsMenu'); - describe.only('spaces', () => { + describe('spaces', () => { describe('space with no features disabled', () => { before(async () => { await spacesService.create({ @@ -44,15 +44,11 @@ export default function({ getPageObjects, getService }: FtrProviderContext) { }); it(`endpoint management shows 'Manage Endpoints'`, async () => { - await pageObjects.common.navigateToActualUrl( - 'endpoint', - '/management', - { - basePath: '/s/custom_space', - ensureCurrentUrl: false, - shouldLoginIfPrompted: false, - } - ); + await pageObjects.common.navigateToActualUrl('endpoint', '/management', { + basePath: '/s/custom_space', + ensureCurrentUrl: false, + shouldLoginIfPrompted: false, + }); await testSubjects.existOrFail('management'); }); });