From 55603db80c196925991784acbc155ba8a65e0a0c Mon Sep 17 00:00:00 2001 From: Anton Dosov Date: Thu, 16 Apr 2020 11:46:43 +0200 Subject: [PATCH] review nits --- .../dashboard/public/application/dashboard_state_manager.ts | 4 ++-- x-pack/test/functional/apps/maps/embeddable/dashboard.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/dashboard/public/application/dashboard_state_manager.ts b/src/plugins/dashboard/public/application/dashboard_state_manager.ts index b2088a13d08d64..b03ea95069a3da 100644 --- a/src/plugins/dashboard/public/application/dashboard_state_manager.ts +++ b/src/plugins/dashboard/public/application/dashboard_state_manager.ts @@ -627,8 +627,8 @@ export class DashboardStateManager { if (state.viewMode === ViewMode.VIEW) { const { panels, ...stateWithoutPanels } = state; return stateWithoutPanels; - } else { - return state; } + + return state; } } diff --git a/x-pack/test/functional/apps/maps/embeddable/dashboard.js b/x-pack/test/functional/apps/maps/embeddable/dashboard.js index 01f9368606160f..9027bb5309ff83 100644 --- a/x-pack/test/functional/apps/maps/embeddable/dashboard.js +++ b/x-pack/test/functional/apps/maps/embeddable/dashboard.js @@ -114,7 +114,7 @@ export default function({ getPageObjects, getService }) { }); // see https://github.com/elastic/kibana/issues/61596 on why it is specific to maps - it("dashboard's back button should work", async () => { + it("dashboard's back button should navigate to previous page", async () => { await PageObjects.common.navigateToApp('dashboard'); await PageObjects.dashboard.preserveCrossAppState(); await PageObjects.dashboard.loadSavedDashboard('map embeddable example');