From bd2078e4b5207a26fe90aadc61096e43f5fb91f4 Mon Sep 17 00:00:00 2001 From: Kevin Qualters Date: Fri, 26 May 2023 17:22:28 +0000 Subject: [PATCH] getDataViewStateFromIndexFields was using wrong type as part of a cast --- .../public/common/containers/source/use_data_view.tsx | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/x-pack/plugins/security_solution/public/common/containers/source/use_data_view.tsx b/x-pack/plugins/security_solution/public/common/containers/source/use_data_view.tsx index 5803e3fc6cb04e..22b943576814f2 100644 --- a/x-pack/plugins/security_solution/public/common/containers/source/use_data_view.tsx +++ b/x-pack/plugins/security_solution/public/common/containers/source/use_data_view.tsx @@ -11,7 +11,7 @@ import { useDispatch } from 'react-redux'; import memoizeOne from 'memoize-one'; import type { BrowserField } from '@kbn/timelines-plugin/common'; import { getCategory } from '@kbn/triggers-actions-ui-plugin/public'; -import type { DataViewFieldBase } from '@kbn/es-query'; +import type { DataView } from '@kbn/data-views-plugin/public'; import { useKibana } from '../../lib/kibana'; import { sourcererActions } from '../../store/sourcerer'; @@ -48,11 +48,7 @@ interface DataViewInfo { * VERY mutatious on purpose to improve the performance of the transform. */ export const getDataViewStateFromIndexFields = memoizeOne( - ( - _title: string, - fields: DataViewFieldBase[], - _includeUnmapped: boolean = false - ): DataViewInfo => { + (_title: string, fields: DataView['fields'], _includeUnmapped: boolean = false): DataViewInfo => { // Adds two dangerous casts to allow for mutations within this function type DangerCastForMutation = Record; @@ -66,7 +62,7 @@ export const getDataViewStateFromIndexFields = memoizeOne( if (acc.browserFields[category].fields == null) { acc.browserFields[category].fields = {}; } - acc.browserFields[category].fields[field.name] = field as unknown as BrowserField; + acc.browserFields[category].fields[field.name] = field.spec as BrowserField; return acc; },