From ce286f543e4bd4d72ec7ffefac3a410cac2eaf0f Mon Sep 17 00:00:00 2001
From: James Gowdy <jgowdy@elastic.co>
Date: Tue, 21 Jan 2020 15:25:58 +0000
Subject: [PATCH] [ML] Adding missing job groups to recognizer wizard (#55392)

---
 .../application/jobs/new_job/recognize/page.tsx     | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/x-pack/legacy/plugins/ml/public/application/jobs/new_job/recognize/page.tsx b/x-pack/legacy/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
index 141ed5d1bbb8ff..c4a96d9e373c8d 100644
--- a/x-pack/legacy/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
+++ b/x-pack/legacy/plugins/ml/public/application/jobs/new_job/recognize/page.tsx
@@ -77,6 +77,7 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
   const [kibanaObjects, setKibanaObjects] = useState<KibanaObjects>({});
   const [saveState, setSaveState] = useState<SAVE_STATE>(SAVE_STATE.NOT_SAVED);
   const [resultsUrl, setResultsUrl] = useState<string>('');
+  const [existingGroups, setExistingGroups] = useState(existingGroupIds);
   // #endregion
 
   const {
@@ -109,6 +110,10 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
       setKibanaObjects(kibanaObjectsResult);
 
       setSaveState(SAVE_STATE.NOT_SAVED);
+
+      // mix existing groups from the server with the groups used across all jobs in the module.
+      const moduleGroups = [...response.jobs.map(j => j.config.groups || [])].flat();
+      setExistingGroups([...new Set([...existingGroups, ...moduleGroups])]);
     } catch (e) {
       // eslint-disable-next-line no-console
       console.error(e);
@@ -222,6 +227,12 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
       ...jobOverrides,
       [job.job_id as string]: job,
     });
+    if (job.groups !== undefined) {
+      // add newly added jobs to the list of existing groups
+      // for use when editing other jobs in the module
+      const groups = [...new Set([...existingGroups, ...job.groups])];
+      setExistingGroups(groups);
+    }
   };
 
   const isFormVisible = [SAVE_STATE.NOT_SAVED, SAVE_STATE.SAVING].includes(saveState);
@@ -304,7 +315,7 @@ export const Page: FC<PageProps> = ({ moduleId, existingGroupIds }) => {
                 jobs={jobs}
                 jobPrefix={jobPrefix}
                 saveState={saveState}
-                existingGroupIds={existingGroupIds}
+                existingGroupIds={existingGroups}
                 jobOverrides={jobOverrides}
                 onJobOverridesChange={onJobOverridesChange}
               />