From e7478d57391bd17da0a7cb61cb3309a288f3ab34 Mon Sep 17 00:00:00 2001
From: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Date: Mon, 27 Nov 2023 13:55:50 -0500
Subject: [PATCH] [Fleet] Do not uninstall package on reinstall error (#171880)

---
 .../plugins/fleet/server/services/epm/packages/install.ts   | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/x-pack/plugins/fleet/server/services/epm/packages/install.ts b/x-pack/plugins/fleet/server/services/epm/packages/install.ts
index 40db0c76dd66a0..c7a3d4638057e0 100644
--- a/x-pack/plugins/fleet/server/services/epm/packages/install.ts
+++ b/x-pack/plugins/fleet/server/services/epm/packages/install.ts
@@ -239,12 +239,16 @@ export async function handleInstallPackageFailure({
   // if there is an unknown server error, uninstall any package assets or reinstall the previous version if update
   try {
     const installType = getInstallType({ pkgVersion, installedPkg });
-    if (installType === 'install' || installType === 'reinstall') {
+    if (installType === 'install') {
       logger.error(`uninstalling ${pkgkey} after error installing: [${error.toString()}]`);
       await removeInstallation({ savedObjectsClient, pkgName, pkgVersion, esClient });
       return;
     }
 
+    if (installType === 'reinstall') {
+      logger.error(`Failed to reinstall ${pkgkey}: [${error.toString()}]`, { error });
+    }
+
     await updateInstallStatus({ savedObjectsClient, pkgName, status: 'install_failed' }).catch(
       (err) => {
         if (!SavedObjectsErrorHelpers.isNotFoundError(err)) {