Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new exclude/include syntax for terms aggregations #10159

Closed
epixa opened this issue Feb 2, 2017 · 2 comments · Fixed by #10193
Closed

Use the new exclude/include syntax for terms aggregations #10159

epixa opened this issue Feb 2, 2017 · 2 comments · Fixed by #10193
Assignees
@ppisljar
Labels
blocker Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v6.0.0-alpha1 v6.0.0

Comments

@epixa
Copy link
Contributor

epixa commented Feb 2, 2017

We're currently using an outdated object syntax for exclude/include. This syntax was accidentally removed in Elasticsearch 5.2.0 but will be added back. However, it will almost certainly be removed permanently in 6.0, so we should update to the new syntax for all new saves. We should show a deprecation warning for any saved usages of the old syntax, but resaving the vis should update it to the new syntax.
@epixa epixa added blocker v6.0.0 Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement labels Feb 2, 2017
@epixa
Copy link
Contributor Author

epixa commented Feb 2, 2017

This is a blocker for 6.0, but we should get a change out as soon as possible.

@epixa
Copy link
Contributor Author

epixa commented Feb 2, 2017

/cc @ppisljar @thomasneirynck

@epixa epixa mentioned this issue Feb 2, 2017
Closed
@ppisljar ppisljar self-assigned this Feb 2, 2017
@ppisljar ppisljar mentioned this issue Feb 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
blocker Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v6.0.0-alpha1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate terms include/exclude to new format ppisljar/kibana
2 participants
@epixa @ppisljar