Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to quickly reapply query_string search in surrounding documents view #22478

Open
ppf2 opened this issue Aug 29, 2018 · 9 comments
Open

Comments

@ppf2
Copy link
Member

@ppf2 ppf2 commented Aug 29, 2018

If you have a filter/query specified from the discover screen and then view surrounding documents, the surrounding documents view will lose the filter/query when displaying the results.

While the surrounding documents view allow end users to add filters to narrow down the scope of the view manually, it can be helpful to provide a way for the end users to quickly reapply the same filters again without having to manually recreate the same filters as before from the surrounding documents view. Maybe we can carry over the filter/query from the discover page to the surrounding documents view as placeholders and provide an option to the end users to re-apply the same filters (if desired).

@Bargs

This comment has been minimized.

Copy link
Contributor

@Bargs Bargs commented Sep 10, 2018

@ppf2 let me know if I'm misunderstanding you, but what you're asking should already be possible. We carry over any of your filters from Discover in a disabled state, and then can be reapplied individually or all at once using the actions menu. Gif:

contextfilters

@Bargs Bargs added feedback_needed and removed triage_needed labels Sep 10, 2018
@ppf2

This comment has been minimized.

Copy link
Member Author

@ppf2 ppf2 commented Sep 11, 2018

@Bargs Do we have similar functionality for users with existing saved searches that have query_string from the Discover screen? Because these cannot be added as pinned filters, they are not getting carried over.

@Bargs

This comment has been minimized.

Copy link
Contributor

@Bargs Bargs commented Sep 11, 2018

No, there's no way to apply a query bar query to the context view at the moment. So you specifically want the query to persist?

@ppf2 ppf2 changed the title Provide a way to quickly reapply filters in surrounding documents view Provide a way to quickly reapply query_string search in surrounding documents view Sep 11, 2018
@ppf2

This comment has been minimized.

Copy link
Member Author

@ppf2 ppf2 commented Sep 11, 2018

Thanks for confirming. It will be nice for the surrounding view to persist the query bar query as well (i.e. persist the "query state" regardless of whether the corpus is narrowed down via the query bar and/or as an explicit filter addition). Thx!

@Bargs

This comment has been minimized.

Copy link
Contributor

@Bargs Bargs commented Sep 11, 2018

Ok, we'll have to give that some thought. Many users will not want the query bar to persist and we don't currently have a "disabled state" for the query bar like we do for the filters so we can't just persist it in a disabled state by default. Might require a UI change to the query bar. Or, perhaps we could turn the query bar query into a filter in the context view so that it can be enabled/disabled like all the others.

@legrego

This comment has been minimized.

Copy link
Contributor

@legrego legrego commented Nov 21, 2019

@data-dude

This comment has been minimized.

Copy link

@data-dude data-dude commented Nov 22, 2019

When I run Kibana 7.2 or 7.4.2 and click 'view surrounding documents' the pinned filter gets lost. Users have to add the filter and refresh every time.

@data-dude

This comment has been minimized.

Copy link

@data-dude data-dude commented Nov 22, 2019

I noticed that when i hover over the link for 'view surrounding documents' there's no value for the filter even though i have a filter and it's pinned. And when I click reset query I then see a value in the filter. So for some reason when you initially pin a filter that link is missing the filter, but when you click reset it appears again. If you click the reset link and go to the context view it's greyed out and you have to reenable it but at least it's there.

@data-dude

This comment has been minimized.

Copy link

@data-dude data-dude commented Nov 22, 2019

So right now i tell users when they hit the page

  1. click 'reset search'.
  2. then search on what they are looking for.
  3. Find the record and click 'view surrounding documents'.
  4. Then re-enable filter and refresh.

It would be nice if they didn't have to click reset search and then later re-enable filter and refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.