Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Timezones #23075

Open
kibanamachine opened this issue Apr 18, 2018 · 0 comments
Open

Handle Timezones #23075

kibanamachine opened this issue Apr 18, 2018 · 0 comments

Comments

@kibanamachine
Copy link

@kibanamachine kibanamachine commented Apr 18, 2018

Original comment by @cqliu1:

Currently, Canvas doesn't handle timezones very well. Dates are created with no specified timezone, and without a specified timezone, moment will display the time based on the user's locale. We should set a default timezone and allow the user to pass in timezone as an arg in the date functions. We should write tests that simulate running the date functions in different browsers with different timezones.

Note: The common functions date, formatdate, and rounddate are currently using moment.utc() to treat all dates as UTC dates as a temporary fix to keep tests from breaking in different timezones (PR LINK REDACTED).

@cqliu1 cqliu1 added the impact:high label May 29, 2019
@cqliu1 cqliu1 added loe:week and removed loe:days labels Oct 4, 2019
@timductive timductive added this to Up Next in canvas via automation Oct 17, 2019
@timductive timductive moved this from Up Next to To do in canvas Oct 17, 2019
@timductive timductive moved this from To do to In progress in canvas Oct 24, 2019
@cqliu1 cqliu1 self-assigned this Oct 25, 2019
@w33ble w33ble mentioned this issue Dec 11, 2019
0 of 5 tasks complete
@timductive timductive moved this from In progress to To do in canvas Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
canvas
  
To do
2 participants
You can’t perform that action at this time.