Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Socket connection is always created #27175

Closed
w33ble opened this issue Dec 13, 2018 · 4 comments
Closed

[Regression] Socket connection is always created #27175

w33ble opened this issue Dec 13, 2018 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@w33ble
Copy link
Contributor

w33ble commented Dec 13, 2018

Kibana version: 6.6+

Describe the bug:

The client side of the connection is always created when Kibana is loaded. This is a partial regression of the fixes in #24247.

This was introduced as part of #26068.

Steps to reproduce:

  1. Open your debugger console
  2. Load Kibana

Expected behavior:

The socket client should not be started unless an application requests it. I believe Canvas is still the only one that does.

Screenshots (if relevant):

screenshot 2018-12-13 16 28 52

@w33ble w33ble added bug Fixes for quality problems that affect the customer experience blocker Team:Visualizations Visualization editors, elastic-charts and infrastructure v6.6.0 labels Dec 13, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@ppisljar
Copy link
Member

  1. canvas is no longer the only one requiring this, as every kibana visualization now uses the interpreter.
  2. seemed to me that in canvas we created the socket on init, before anything would be using it (it was not initialized on first use, but before) ... i moved same behavrior to interpreter, where it might not make sense anymore.

@w33ble
Copy link
Contributor Author

w33ble commented Dec 17, 2018

It loads the server on init, which is fine, and that's not what this issue is about. The issue is that load_browser_plugins just calls createSocket on import, so the socket is always initialized on the client. The socket client shouldn't try to connect until an app uses the socket (ie. apps should probably make their own calls to createSocket).

@timroes
Copy link
Contributor

timroes commented May 22, 2019

This is no longer relevant, since websocket support has been removed .. for now.

@timroes timroes closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants