Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of x-pack directory should not differ between dev and distributions #31471

Open
epixa opened this Issue Feb 19, 2019 · 3 comments

Comments

4 participants
@epixa
Copy link
Member

epixa commented Feb 19, 2019

The x-pack directory exists in the root of the project during development, but when you run the build task to create artifacts, it moves to node_modules/x-pack. This means there is no reliable way to consistency import oss plugin and core code statically inside x-pack.

It's location should remain static just like our other source code.

I think one of the reasons this was done in the past was to deduplicate shared dependencies, but this should be handled effectively enough now with yarn workspaces.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 19, 2019

@spalger

This comment has been minimized.

Copy link
Member

spalger commented Feb 23, 2019

The other reason we did that was to enforce that nobody was doing relative imports to core, but plans change

@tylersmalley

This comment has been minimized.

Copy link
Member

tylersmalley commented Mar 7, 2019

I have put up a draft PR here: #32722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.