Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Kibana crashes on reopening Console Settings #35392

Closed
dmlemeshko opened this issue Apr 21, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@dmlemeshko
Copy link
Contributor

commented Apr 21, 2019

Kibana version:master

Elasticsearch version:master

Server OS version:10.14.4

Browser version:Firefox 66.0.3

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):master

Describe the bug: Kibana crashes on reopening Console Settings

Steps to reproduce:

  1. Go to the Console page
  2. Click Settings link
  3. Change font size, click Save
  4. Click Settings link again

Expected behavior: Console Settings are shown

Screenshots (if relevant):
Apr-21-2019 19-54-36

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

TypeError: saved.shift is not a function (http://localhost:5620/built_assets/dlls/vendors.bundle.dll.js line 20063 > eval:5481)

Version: 8.0.0
Build: 9007199254740991
Error: TypeError: saved.shift is not a function (http://localhost:5620/built_assets/dlls/vendors.bundle.dll.js line 20063 > eval:5481)
./src/legacy/ui/public/notify/notify.js/window.onerror@http://localhost:5620/bundles/commons.bundle.js:59809:32
handler@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:5447:18
dispatch@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:5232:16
add/elemData.handle@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:5040:6
trigger@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:8461:5
trigger/<@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:8539:4
each@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:367:10
each@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:202:10
trigger@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:8538:10
jQuery.fn[name]@webpack://%5Bname%5D/./node_modules/jquery/dist/jquery.js?:10436:4
link/<@http://localhost:5620/bundles/commons.bundle.js:48978:11
timeout/timeoutId<@webpack://%5Bname%5D/./node_modules/angular/angular.js?:20566:28
completeOutstandingRequest@webpack://%5Bname%5D/./node_modules/angular/angular.js?:6428:7
Browser/self.defer/timeoutId<@webpack://%5Bname%5D/./node_modules/angular/angular.js?:6707:7

Any additional context:

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 21, 2019

Pinging @elastic/es-ui

@cjcenizal cjcenizal self-assigned this Apr 22, 2019

@cjcenizal

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

Thanks for reporting this! I was able to reproduce. Reverting #35177 seems to fix the problem so I believe this was caused by a JQuery upgrade.

tylersmalley added a commit that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (#35908)
Fixes #35419
Fixes #35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit to tylersmalley/kibana that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (elastic#35908)
Fixes elastic#35419
Fixes elastic#35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (#35908) (#35928)
Fixes #35419
Fixes #35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.