Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jQuery 3.4.0 causing "saved.shift is not a function" error #35419

Closed
cjcenizal opened this issue Apr 22, 2019 · 7 comments

Comments

Projects
None yet
4 participants
@cjcenizal
Copy link
Contributor

commented Apr 22, 2019

This is the same bug as reported by #35392.

In Chrome, on master, you can reproduce this bug by going into Watcher, creating a threshold watch, and trying to edit the expression.

watcher_jquery_bug

I believe this is due to the upgrade to jQuery 3.4.0 (#35177). Reverting the commit solves the problem (8bd06fc).

CC @kobelb @jbudz

@elasticmachine

This comment has been minimized.

Copy link

commented Apr 22, 2019

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Looks like the issue is in jQuery: jquery/jquery#4350. They plan on shipping a fix in 3.4.1 in the next couple weeks. When they do, we'll upgrade and ensure it fixes the reported bugs.

@tylersmalley

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

In the meantime, do you think we should revert the upgrade? @kobelb?

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@tylersmalley I think that'd probably be best, if that doesn't create problems.

@kobelb

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

In the meantime, do you think we should revert the upgrade? @kobelb?

We can, if it's causing problems for people. My original reasoning for keeping it at 3.4.0 was it gave us more time to determine if there are any other issues with the upgrade that we weren't aware of, but if it's hurting people's worflows, we can downgrade.

@tylersmalley

This comment has been minimized.

Copy link
Member

commented May 1, 2019

This issue should be resolved in jQuery 3.4.1

jquery/jquery@24d71ac

tylersmalley added a commit to tylersmalley/kibana that referenced this issue May 1, 2019

Upgrade jQuery to 3.4.1
Fixes elastic#35419

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley

This comment has been minimized.

Copy link
Member

commented May 1, 2019

3.4.1 has been released and I have opened up a PR here: #35908

tylersmalley added a commit that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (#35908)
Fixes #35419
Fixes #35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit to tylersmalley/kibana that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (elastic#35908)
Fixes elastic#35419
Fixes elastic#35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit that referenced this issue May 2, 2019

Upgrade jQuery to 3.4.1 (#35908) (#35928)
Fixes #35419
Fixes #35392

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.