Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APM app page title should reflect what's showing #41456

Closed
jamiesmith opened this issue Jul 18, 2019 · 3 comments · Fixed by #44296
Closed

APM app page title should reflect what's showing #41456

jamiesmith opened this issue Jul 18, 2019 · 3 comments · Fixed by #44296
Assignees
@smith @katrin-freihofner
Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:APM All issues that need APM UI Team support

Comments

@jamiesmith
Copy link
Contributor

Currently the APM app only shows the last breadcrumb as the page title (in the tab list, for example).

image

Describe the feature:
The page title should be reflective of the App & any specialization being shown, similar to the Infra app, which indicates what it's showing:

Infrastructure | Inventory - Kibana
Infrastructure | Metrics Explorer - Kibana

Perhaps the APM App can show:

  • APM | Services - Kibana (when on the base page)
  • APM | <Service> - Kibana (when on a named service) - examples
    • APM | opbeans-python | Transactions - Kibana)
    • APM | opbeans-python | Transactions | GET opbeans.views.home - Kibana)
    • APM | opbeans-python | Errors - Kibana)

Describe a specific use case for the feature:
It's not at all uncommon to have multiple tabs or pages open- with multiple APM app tabs open they might all just say "Transactions" or "Errors", without knowing which is which.
@jamiesmith jamiesmith added the Team:APM All issues that need APM UI Team support label Jul 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv sorenlouv added [zube]: Inbox enhancement New value added to drive a business result labels Jul 24, 2019
@katrin-freihofner
Copy link
Contributor

I see two use cases here:

  1. I want to compare multiple attributes (Errors, Metrics) of one entity (Service)
  2. I want to compare the same attributes of multiple entities

I currently have 20+ open tabs 😋- so the title should start with the most differential part in my opinion.

What about:
[Name of transaction] | Transactions | [Name of service] | APM
[Transactions, Errors, Metrics] | [Name of service] | APM

Which would mean:
[Name of monitor] | Uptime
Inventory | Infrastructure

@hbharding I would also like to hear your opinion.

@jamiesmith
Copy link
Contributor Author

Yeah, that's exactly the rationale, on both counts.

@sorenlouv sorenlouv added groom-ready impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed groom-ready labels Jul 26, 2019
@sorenlouv sorenlouv mentioned this issue Aug 17, 2019
Closed
@smith smith self-assigned this Aug 28, 2019
smith added a commit to smith/kibana that referenced this issue Aug 28, 2019
@smith
[APM] More descriptive page titles
2445c6a 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Fixes elastic#41456.
@smith smith mentioned this issue Aug 28, 2019
Merged
7 tasks
smith added a commit to smith/kibana that referenced this issue Aug 28, 2019
@smith
[APM] More descriptive page titles
bf669c4 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes elastic#41456.
smith added a commit that referenced this issue Aug 28, 2019
@smith
[APM] More descriptive page titles (#44296)
ec713f2 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on #41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes #41456.
smith added a commit to smith/kibana that referenced this issue Aug 28, 2019
@smith
[APM] More descriptive page titles (elastic#44296)
0a3bbd7 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes elastic#41456.
smith added a commit to smith/kibana that referenced this issue Sep 5, 2019
@smith
[APM] More descriptive page titles (elastic#44296)
d903ecb 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes elastic#41456.
sorenlouv pushed a commit to sorenlouv/kibana that referenced this issue Sep 9, 2019
@smith @sorenlouv
[APM] More descriptive page titles (elastic#44296)
388fbe9 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes elastic#41456.
sorenlouv pushed a commit to sorenlouv/kibana that referenced this issue Sep 9, 2019
@smith @sorenlouv
[APM] More descriptive page titles (elastic#44296)
5afa8ea 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on elastic#41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes elastic#41456.
sorenlouv added a commit that referenced this issue Sep 9, 2019
@sorenlouv
[APM] More descriptive page titles (#44296) (#45190)
9d1e423 
Instead of using only the text of the last breadcrumb for the page title, use the breadcrumbs to create a reverse list of items (since in the page title we want the most relevant item at the beginning) that are pipe-separated.

This only affects the page titles in APM, since Infra uses a different mechanism for breadcrumbs and page titles.

The implementation doesn't exactly match the discussion on #41456, and there's no truncation, but it should be an improvement.

Also update the tests so that they more accurately reflect the routes actually being used in the app.

Fixes #41456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

@katrin-freihofner katrin-freihofner

Labels
enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:APM All issues that need APM UI Team support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] More descriptive page titles smith/kibana
5 participants
@smith @sorenlouv @jamiesmith @elasticmachine @katrin-freihofner