Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in Canvas expression editor #42829

Open
Benny-Git opened this issue Aug 7, 2019 · 3 comments
Open

Comments in Canvas expression editor #42829

Benny-Git opened this issue Aug 7, 2019 · 3 comments

Comments

@Benny-Git
Copy link

@Benny-Git Benny-Git commented Aug 7, 2019

Describe the feature:

Allow a way to write comments in the expression editor syntax.
I've tried #comment and //comment, as well as and /comment/ to no avail. Searching on the documentation didn't help either.
I know that JSON doesn't support comments natively, but maybe we can have a dedicated "comment" element somewhere that Canvas explicitely ignores?

Describe a specific use case for the feature:

I have created a rather complex expression with multiple pipes to work around a Canvas limitation (timezones), and want to document how and why I did it, with short instructions on how I think it should work once the limitation is resolved.

Link to discussion: https://discuss.elastic.co/t/193951
@chrisdavies asked me to open a feature request here

@elasticmachine

This comment has been minimized.

Copy link
Contributor

@elasticmachine elasticmachine commented Aug 7, 2019

@elasticmachine

This comment has been minimized.

Copy link
Contributor

@elasticmachine elasticmachine commented Aug 7, 2019

@timroes timroes added the enhancement label Aug 7, 2019
@timroes

This comment has been minimized.

Copy link
Contributor

@timroes timroes commented Aug 7, 2019

I think it would be nice if we could have comments as a concept in the expressions themself not just canvas, so we can actually use comments in other placing using the expressions in Kibana.

@alexh97 alexh97 added this to To do in kibana-app-arch Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.