Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] FIx RUM page info display #42930

Closed
vigneshshanmugam opened this issue Aug 8, 2019 · 3 comments

Comments

@vigneshshanmugam
Copy link
Member

commented Aug 8, 2019

  • APM Server version - 7.3.0

  • RUM transaction json to the intake API. Check context.page info which has correct page URL.

{
  "transaction": {
    "context": {
      "user": {
        "id": "userId",
        "username": "username",
        "email": "email"
      },
      "custom": {
        "testContext": "testContext"
      },
      "tags": {
        "testTagKey": "testTagValue"
      },
      "page": {
        "referer": "",
        "url": "http://localhost:8000/test/e2e/general-usecase/"
      },
      "response": {
        "transfer_size": 914,
        "encoded_body_size": 621,
        "decoded_body_size": 621
      }
    },
    "span_count": {
      "started": 8
    },
    "sampled": true
  }
}
  • Transaction document
"transaction": {
      "custom": {
        "testContext": "testContext"
      },
      "page": {
        "referer": "",
        "url": "http://localhost:8000/test/e2e/general-usecase/"
      },
      "span_count": {
        "started": 8
      }
}
  • UI is expecting the value in the format
const url = transaction.context.page.url || transaction.url.full || NA

Screenshot 2019-08-08 at 11 05 03

I am not sure if its a issue on UI or APM server side, But the code on UI has not changed for months.

@simitt

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Since 7.0 we don't store any information inside events nested under context any more. The change was implemented with https://github.com/elastic/apm-server/pull/1863/files. After moving a lot of fields to be ECS compliant, the term context was not meaningful any more and we decided to remove it.
This change probably got lost in the large amount of field changes. I'd say it needs to be fixed in the UI. @elastic/apm-ui do you agree?

@graphaelli graphaelli transferred this issue from elastic/apm-server Aug 8, 2019

@graphaelli graphaelli added the Team:apm label Aug 8, 2019

@graphaelli graphaelli changed the title [RUM] context.page info from transaction is mapped wrongly [APM] FIx RUM page info display Aug 8, 2019

@graphaelli

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Transferred over from an apm-server issue, we should change the UI to use transaction.context.page.url -> transaction.page.url. transaction.context should not actually be in use anywhere.

@sqren

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

@elastic/apm-ui do you agree?

Yes, agree this is a ui issue.

@sqren sqren self-assigned this Aug 8, 2019

@sqren sqren closed this in #42940 Aug 9, 2019

@zube zube bot added [zube]: Done and removed [zube]: In Progress labels Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.