Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign DocViewer table layout #43577

Closed
kertal opened this issue Aug 20, 2019 · 5 comments
Closed

Redesign DocViewer table layout #43577

kertal opened this issue Aug 20, 2019 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@kertal
Copy link
Member

kertal commented Aug 20, 2019

Summary

With merging the reactified DocViewer (#42116) and the soon to be finished reactification of the DocViewer table layout (#43240). It would a a good time to work on the redesign of the table layout. It's shared by Discover, Discover's Context and Discover's Doc view. So far only parts of it use EUI, icons are still provided by Font Awesome, objects in arrays are just displayed as JSON and don't provide filter functionality, ...

Discover

image
With the introduction of data grid (elastic/eui#1689), it's likely that it will be displayed as flyout

Discover's context

image
Same as Discover

Discover's doc

image

Icons

Should be replaced. Would be nice, if e.g. it was displayed which column is currently active.
Question is, if they should be displayed only when hovered
Bildschirmfoto 2019-08-21 um 07 41 03

Object in arrays

There was an fold/unfold button introduced recently, for long content:
Bildschirmfoto 2019-08-21 um 07 44 46
It should be improved for unfold/fold objects in arrays. So initially you see the number of objects in arrays, when unfolded, the array items become part of the table, so you can add columns, filter, etc.

More?

ideas?

Related

@kertal kertal self-assigned this Aug 20, 2019
@kobelb kobelb added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@kobelb kobelb added the Feature:Discover Discover Application label Aug 20, 2019
@kertal kertal added the Meta label Aug 21, 2019
@0asp0
Copy link

0asp0 commented Aug 23, 2019

I was asked here (https://discuss.elastic.co/t/saved-search-is-minimum-column-width-before-breaking-the-line-configurable/196356) to place my ideas for changing in this issue.

If you like, I can also create separate issues which can be linked here.

This feature is referencing to Discover's context.

Possibility to add min / max column width and height:
If you add a lot of columns for display, the columns get shrinked in width, so that as much columns as possible are displayed at a screen.
image

As result these columns get more and more unreadable.
It would be nice to be able to set the following parameters:

  • minWidth (in pixels or chars):
    ** a column must not get shrinked below this given size in width dimension. Only if all values and column name are smaller than the minWidth the column can get less wide. So we do not waste space if column's name and value are very short.
  • maxHeight
    ** when shrinking the value will be displayed in multiple lines before being truncated in discovery view. It would be nice if one can define the max number of lines which will be used in this case.

I think this feature would increase readability a lot when working with many selected fields / columns.

@kertal
Copy link
Member Author

kertal commented Aug 23, 2019

thx @0asp0 for your input. This will be addressed in a related redesign step, the introduction of data grid: elastic/eui#1689, which will allow you to resize columns

@cchaos cchaos added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Aug 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@kertal kertal added this to To do in Discover Oct 14, 2019
@kertal kertal moved this from To do to Meta/Discuss in Discover Oct 15, 2019
@kertal kertal moved this from Meta/Discuss to EuiDataGrid / Design in Discover Oct 1, 2020
@timroes
Copy link
Contributor

timroes commented Jun 24, 2021

I'll close this in favor of the ongoing datagrid effort and more specific issues we have for separate tasks and #97649 as a successor.

@timroes timroes closed this as completed Jun 24, 2021
Discover automation moved this from EuiDataGrid / Design to Done Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Meta Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Development

No branches or pull requests

9 participants