Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Incorrect error count in trace header #45258

Open
sqren opened this issue Sep 10, 2019 · 5 comments

Comments

@sqren
Copy link
Member

commented Sep 10, 2019

Introduced in #44274

The number of errors in the trace header doesn't match the number of errors in the actual trace. In the screenshot below there are 4 errors in the trace header but only 2 in the trace.

Screen Shot 2019-09-10 at 15.15.54.png

It may happen that an agent sends up errors that occured in a transaction but the transaction itself is never sent. Likelyhood of this happening is rather small though.

Repro url: https://apm.elstc.co/ovk/app/apm#/services/client/transactions/view?rangeFrom=2019-08-27T21:11:00.000Z&rangeTo=2019-08-27T21:37:30.000Z&refreshPaused=true&refreshInterval=0&traceId=17a2c6b6ed58694d38c7c58f80df51d5&transactionId=d8cfb4f38bed3dce&transactionName=customers&transactionType=page-load&detailTab=timeline&_g=()&flyoutDetailTab=&waterfallItemId=

@elasticmachine

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Pinging @elastic/apm-ui

@formgeist

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

@sqren Perhaps unrelated to this issue, but was it discussed to add a link to the Errors overview page with the trace.id value filtered to show all the related errors on that summary badge, 4 errors? I was expecting that I could click it like I can the numbered error counts in the Timeline.

@sqren

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

Perhaps unrelated to this issue, but was it discussed to add a link to the Errors overview page with the trace.id value filtered to show all the related errors on that summary badge, 4 errors? I was expecting that I could click it like I can the numbered error counts in the Timeline.

Not unrelated at all. That would actually mitigate this problem but since we are now displaying the error count for the full trace, there could be errors for multiple services. We currently don't have an error overview page that shows errors across multiple services (they are always scoped by a service). This reminds me a little of the talk we had about making service.name an optional filter. Then we could use the existing error overview page without any changes.

@formgeist

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2019

Not unrelated at all. That would actually mitigate this problem but since we are now displaying the error count for the full trace, there could be errors for multiple services. We currently don't have an error overview page that shows errors across multiple services (they are always scoped by a service).

Right, I see how that's a challenge.

This reminds me a little of the talk we had about making service.name an optional filter. Then we could use the existing error overview page without any changes.

But obviously that opens up a whole slurry of navigation changes that we'd need to make. I understand that could potentially change it and add the Service as a filter, but that's not really the ideal experience. I imagine we'd want to move the Errors page out of the Service area, and into its own like Services and Traces. Not sure if that's anything we want to act upon right now.

@sqren

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2019

But obviously that opens up a whole slurry of navigation changes that we'd need to make. I understand that could potentially change it and add the Service as a filter, but that's not really the ideal experience. I imagine we'd want to move the Errors page out of the Service area, and into its own like Services and Traces. Not sure if that's anything we want to act upon right now.

Agree. Let's punt on it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.