Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations need to register itself #4676

Closed
timroes opened this issue Aug 14, 2015 · 3 comments
Closed

Visualizations need to register itself #4676

timroes opened this issue Aug 14, 2015 · 3 comments

Comments

@timroes
Copy link
Contributor

@timroes timroes commented Aug 14, 2015

This is more like a question than an issue. In the new plugin system in 4.2.0 you can register new visualization types by adding them to uiExports.visTypes in the constructor of kibana.Plugin.

For the vis to work you have to add its provider to the registry (ui/registry/vis_types) by hand.
Is there a special design reason for the semantic duplication in this case? Wouldn't it be better/cleaner to just return the provider from the module and let the 'plugin system' handle registering it at the registry?

The same also applies for spyModes and fieldFormats.

@rashidkpc
Copy link
Contributor

@rashidkpc rashidkpc commented Aug 18, 2015

Agreed, this needs to be abstracted out to allow visualizations to easily register themselves.

@timroes
Copy link
Contributor Author

@timroes timroes commented Feb 18, 2016

/cc @spalger #elasticon as just discussed, you should totally fix this ;-)

@timroes
Copy link
Contributor Author

@timroes timroes commented Aug 10, 2018

I will close this issue, since this will be solved by the new platform, which will just export objects, and you can have explicit interfaces on them to register. I don't think this needs to change until visualizations switch over to the new platform.

@timroes timroes closed this Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants