Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Change get transaction by trace id url #52252

Closed
cauemarcondes opened this issue Dec 5, 2019 · 1 comment · Fixed by #53756
Closed

[APM] Change get transaction by trace id url #52252

cauemarcondes opened this issue Dec 5, 2019 · 1 comment · Fixed by #53756
Assignees
@cauemarcondes
Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@cauemarcondes
Copy link
Contributor

The current API to get the transaction based on the trace ID is /api/apm/transaction/TRACE_ID, but based on restful principals this is incorrect.
To make it consistent we should change it to /api/apm/traces/{traceId}/root_transaction, and move it to https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/apm/server/routes/traces.ts#L19
@cauemarcondes cauemarcondes added [zube]: Inbox Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture labels Dec 5, 2019
@cauemarcondes cauemarcondes self-assigned this Dec 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes mentioned this issue Dec 5, 2019
Merged
@cauemarcondes cauemarcondes mentioned this issue Dec 6, 2019
Closed
@cauemarcondes cauemarcondes mentioned this issue Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
good first issue low hanging fruit Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
5 participants
@graphaelli @sorenlouv @cjcenizal @elasticmachine @cauemarcondes