Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Expression editor remains visible when you turn off edit mode #52786

Open
cqliu1 opened this issue Dec 11, 2019 · 1 comment
Open

[Canvas] Expression editor remains visible when you turn off edit mode #52786

cqliu1 opened this issue Dec 11, 2019 · 1 comment

Comments

@cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Dec 11, 2019

Kibana version:
master (as of a863dca)

Describe the bug:
If you turn off edit mode while an element is selected with the expression editor open, the sidebar disappears, but the element stays selected in the app state (even though it's not visibly selected) and the expression editor remains in view and is editable.

Steps to reproduce:

  1. Select an element on a workpad
  2. Click the Expression Editor button
  3. Click the lock button up top to turn off edit mode.
  4. Observe the expression editor is still open.

Expected behavior:
All selections should be deselected.

Screenshots (if relevant):
Screen Shot 2019-12-11 at 10 32 08 AM

@elasticmachine

This comment has been minimized.

Copy link
Contributor

@elasticmachine elasticmachine commented Dec 11, 2019

Pinging @elastic/kibana-canvas (Team:Canvas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.