New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for broken fieldFormaters in plugin #6040

Closed
timroes opened this Issue Jan 29, 2016 · 3 comments

Comments

Projects
None yet
5 participants
@timroes
Contributor

timroes commented Jan 29, 2016

In Kibana 4.3 the fieldFormats array in the index.js of a plugin is actually never read out (i.e. the files never loaded). As a workaround if your plugin needs to register field formatters it can just add these files to the visTypes array, since the module itself anyway needs to register itself to the appropriate registry. So it doesn't matter which array visTypes or fieldFormats is used to load the file.

This behaviour is already fixed in the master branch, but unfortunately not in the 4.4 or 4.4.0 branch. It would be great if the appropriate fix could be backported to the 4.4 branch or if possible even to the next 4.3.x patch version (since it's just a bugfix).

I am not very sure, what commit exactly fixed this behaviour, but I am sure @spalger does know :-)
I guess it might have to do something with commit 6eeff7d where the fieldFormats is added to the use array?

Update corrected the commit hash to the more likely commit.

@timroes

This comment has been minimized.

Contributor

timroes commented Jan 29, 2016

Btw, the required map in the UiExports.js was already there in Kibana 4.3.0 btw. So I think it really shouldn't be too much to do, to fix this in 4.3.

@rashidkpc

This comment has been minimized.

Member

rashidkpc commented Feb 3, 2016

@spalger can you look at this?

@rashidkpc rashidkpc added the bug label Feb 3, 2016

@rashidkpc rashidkpc added the v4.4.1 label Feb 3, 2016

@tbragin tbragin added the :Plugins label Feb 10, 2016

@epixa epixa added v4.4.2 and removed v4.4.1 labels Feb 12, 2016

@epixa epixa added v4.4.3 and removed v4.4.2 labels Mar 4, 2016

@epixa

This comment has been minimized.

Member

epixa commented Aug 4, 2016

Sorry this never happened @timroes, but I'm going to close this out since we're not doing any more 4.4/3 releases.

@epixa epixa closed this Aug 4, 2016

@epixa epixa removed the v4.4.3 label Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment