Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent page load in markdown links #68236

Closed
flash1293 opened this issue Jun 4, 2020 · 4 comments
Closed

Prevent page load in markdown links #68236

flash1293 opened this issue Jun 4, 2020 · 4 comments
Labels
Feature:Markdown Markdown visualization feature Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@flash1293
Copy link
Contributor

Markdown visualizations can contain links - if these are linking to other applications within Kibana, a full page load will be triggered even though it's possible to load another app using the Kibana platform application service.

Once #67595 is merged, kibana_react will provide a component RedirectCrossAppLinks which should wrap the rendered markdown. It will intercept all click events and perform a Kibana platform navigation if possible.

@flash1293 flash1293 added Feature:Markdown Markdown visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas-no-ping)

@Dosant
Copy link
Contributor

Dosant commented Dec 3, 2020

This discuss post brought up possible caveat of this regression.

Previously it was possible to remove time range or other piece of global state from destination URL and without page reload destination page would use current state that is was in memory. With page reload it resets to default.

@ThomThomson
Copy link
Contributor

Closing this as there is a workaround where markdown users can use the #/view syntax to link to a dashboard without reloading the page. This works alright for a majority of use cases and we haven't heard any further user complaints.

We can reopen this if the page reloading causes problems once again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Markdown Markdown visualization feature Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants