Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix packages being upgraded accidentally after adding to policy #101542

Merged
merged 1 commit into from Jun 8, 2021

Conversation

jen-huang
Copy link
Contributor

Summary

Fixes #99649. This PR fixes a bug where packages would be upgraded on adding it to an agent policy. How to test:

  1. Force install an older version of a package, i.e. for apache
POST <host>/api/fleet/epm/packages/apache-0.3.0
{
  "force": true
}
  1. Add apache to any agent policy
  2. Go to Integrations > Apache, observe that the version installed should remain as 0.3.0 and it was not accidentally upgraded to the latest version

@jen-huang jen-huang added release_note:fix v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.13.2 labels Jun 7, 2021
@jen-huang jen-huang self-assigned this Jun 7, 2021
@jen-huang jen-huang requested a review from a team as a code owner June 7, 2021 22:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jen-huang jen-huang added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 8, 2021
@jen-huang jen-huang merged commit 0894f67 into elastic:master Jun 8, 2021
@jen-huang jen-huang deleted the fix/add-integration-install branch June 8, 2021 14:56
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 8, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 8, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.13
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 8, 2021
…cy (#101542) (#101613)

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine added a commit that referenced this pull request Jun 8, 2021
…cy (#101542) (#101614)

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
@dikshachauhan-qasource
Copy link

Hi @jen-huang

We have validated this PR on 7.14 Snapshot build and found it available there.

-We are now able to add lower version packages to Policy.

  • Package version is not upgraded to latest version when added under any policy.

Screenshot:
image

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v7.13.2 v7.14.0 v8.0.0
Projects
None yet
5 participants