[canvas][tech-debt] Convert Canvas to use Service Abstractions API#103202
Closed
clintandrewhall wants to merge 1 commit into
Closed
[canvas][tech-debt] Convert Canvas to use Service Abstractions API#103202clintandrewhall wants to merge 1 commit into
clintandrewhall wants to merge 1 commit into
Conversation
3805752 to
b93852a
Compare
b93852a to
8e24f02
Compare
[canvas] Reduce bundle by registering Canvas Plugin API on mount
8e24f02 to
c419d23
Compare
Contributor
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/filters·ts.Canvas app filters filter updates when dropdown is changedStandard OutStack TraceKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/canvas/filters·ts.Canvas app filters filter updates when dropdown is changedStandard OutStack TraceMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
This was referenced Aug 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This converts all of our services to use the safer, more correct service abstractions API we created in Presentation Util. It also attempts to clean up the non-standard usage of the setup and start contracts API.
Expect this to be closed eventually... I wanted to get it in front of @crob611 @poffdeluxe @cqliu1 and @ThomThomson before we kick off another tech-debt week.
Each service will be created individually and reviewed independently, with the first containing the initial setup for each service. Then I'll convert any from
public/libthat remain.In the end, we'll be on a much safer, more predictable, extensible standard.