Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Add ECS mapping editor #107706

Merged
merged 36 commits into from Aug 15, 2021
Merged

[Osquery] Add ECS mapping editor #107706

merged 36 commits into from Aug 15, 2021

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Aug 4, 2021 •
edited

Summary

image

@patrykkopycinski patrykkopycinski self-assigned this Aug 4, 2021
@patrykkopycinski patrykkopycinski added auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Osquery Security Solution Osquery feature release_note:feature Makes this part of the condensed release notes Team:Asset Management Security Asset Management Team v7.15.0 v8.0.0 labels Aug 4, 2021
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
1c6215d 
…ecs-mapping
@patrykkopycinski
WIP
24cafaf
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
bb02740 
…ecs-mapping
@patrykkopycinski
WIP
da2e0cb
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
bd14f11 
…ecs-mapping
@patrykkopycinski
node-sql-parser
9420164
@patrykkopycinski
remove ecs schema
d42e76b
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
a97e951 
…ecs-mapping
@patrykkopycinski
fix license
0a5c1bb
@patrykkopycinski
WIP
3546f11
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
e30efba 
…ecs-mapping
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
9817f18 
…ecs-mapping
@patrykkopycinski
cleanup
0644f6d
@patrykkopycinski
Merge branch 'master' of github.com:elastic/kibana into feat/osquery-…
a12d9e1 
…ecs-mapping
@patrykkopycinski
cleanup
c3be239
@patrykkopycinski patrykkopycinski marked this pull request as ready for review August 12, 2021 13:45
@patrykkopycinski patrykkopycinski requested review from a team as code owners August 12, 2021 13:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

mistic
mistic approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes on code under operations team code owners LGTM

james-elastic
james-elastic approved these changes Aug 13, 2021
View reviewed changes
Copy link

@james-elastic james-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so good with the sql parser! 💯

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
osquery 247 255 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 931.9KB 2.3MB ⚠️ +1.4MB
Unknown metric groups

async chunk count

id before after diff
osquery 6 7 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

@patrykkopycinski patrykkopycinski merged commit c347a7e into elastic:master Aug 15, 2021
@patrykkopycinski patrykkopycinski deleted the feat/osquery-ecs-mapping branch August 15, 2021 23:17
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 15, 2021
@patrykkopycinski @kibanamachine
[Osquery] Add ECS mapping editor (elastic#107706)
a57f3c2
@kibanamachine kibanamachine mentioned this pull request Aug 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 16, 2021
@kibanamachine @patrykkopycinski
[Osquery] Add ECS mapping editor (#107706) (#108641)
9cedaef 
Co-authored-by: Patryk Kopyciński <patryk.kopycinski@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@james-elastic james-elastic james-elastic approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Osquery Security Solution Osquery feature release_note:feature Makes this part of the condensed release notes Team:Asset Management Security Asset Management Team v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @mistic @james-elastic