Fail early on import, and don't prompt to overwrite when failing

[w33ble]

Closes #5694 and #11057

• When JSON.parse fails, show error and exit early
• When importing a non-array, show error and fail early

---

To test, try importing this JSON file (from #5694).

Also try importing a file that is not valid json, by, say, removing a quote from the file.

[ycombinator]

I tried both cases: importing a non-JSON file and importing a JSON file with a syntax error (I tried twice: first, by removing a double quote, and second, by removing a comma). In all cases I get the same error message: "Saved Objects: The file could not be processed.".

Is it possible to produce the new error message you introduced in this PR: "JSON format is invalid and can not be imported."?

[w33ble]

I tried both cases: importing a non-JSON file and importing a JSON file with a syntax error

Those are actually the same case. Both make JSON.parse throw.

You should get the new error when importing a valid JSON file where the root element is not an array, like the example I linked to in the description.

[ycombinator]

Ah, I think I understand now. The "JSON format" in the new error message introduced in this PR refers to the structure of the JSON that Kibana expects for saved objects JSON.

I think perhaps we could change that message to something like "Saved objects file format is invalid and cannot be imported"? The fact that the file contains JSON seems like an implementation detail that the user shouldn't need to care about.

[w33ble]

I like it. PR updated.

[ycombinator]

LGTM.

[BigFunger]

LGTM

[w33ble]

5.x 84d0d65
5.3 20b88b6