Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] React search box tool bar (#10821) #11443

Merged

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Apr 26, 2017

backports #10821

  • Add a react tool bar search box

Create basic react toolbar elements and update uiframework docs

  • Package.json: put back ngreact (edits got overwritten)

  • Add jest tests

  • Combine basic tests into one, eliminate helper functions

  • Address code review comments

  • move tool_bar_footer into it’s own file.
  • some stylistic html changes
  • comments
  • Remove toolbar_with_search_only

It isn’t being used in kibana currently, so we probably don’t need to
support it in our ui_Framework, and the need for the custom
“className="kuiToolBar--searchOnly”” indicates we should resdesign it
if we do need it some day.

  • Fix issue with default to named conversion merge

  • rename commonHtmlProps = requiredProps

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you included unit tests that cover the changes?
  • If submitting code, have you tested and built your code locally prior to submission with npm test && npm run build?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.

* Add a react tool bar search box

Create basic react toolbar elements and update uiframework docs

* Package.json: put back ngreact (edits got overwritten)

* Add jest tests

* Combine basic tests into one, eliminate helper functions

* Address code review comments

- move tool_bar_footer into it’s own file.
- some stylistic html changes
- comments

* Remove toolbar_with_search_only

It isn’t being used in kibana currently, so we probably don’t need to
support it in our ui_Framework, and the need for the custom
“className="kuiToolBar--searchOnly”” indicates we should resdesign it
if we do need it some day.

* Fix issue with default to named conversion merge

* rename commonHtmlProps = requiredProps
@stacey-gammon stacey-gammon merged commit 7d4ce8c into elastic:5.x Apr 26, 2017
@stacey-gammon stacey-gammon deleted the 5-x-react-search-box-visualize branch April 26, 2017 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant