New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_unmapped to geo filters to prevent exceptions #11461

Merged
merged 3 commits into from May 1, 2017

Conversation

Projects
None yet
4 participants
@lukasolson
Member

lukasolson commented Apr 26, 2017

This PR adds an additional parameter, ignore_unmapped to geo_bounding_box filters that are created when you create a map visualization and then select bounds to filter by. This has the effect of ignoring when the index pattern doesn't have a matching geo_point field to filter, which was causing issues on dashboards when one index pattern had a geo_point field while others didn't.

Fixes #9387.

@lukasolson lukasolson self-assigned this Apr 26, 2017

@lukasolson lukasolson requested review from weltenwort and thomasneirynck Apr 26, 2017

@thomasneirynck

This comment has been minimized.

Show comment
Hide comment
@thomasneirynck

thomasneirynck Apr 27, 2017

Contributor

this needs to be rebased for ci to succeed

Contributor

thomasneirynck commented Apr 27, 2017

this needs to be rebased for ci to succeed

@tbragin tbragin added the :Discovery label Apr 27, 2017

@lukasolson lukasolson requested a review from Bargs Apr 28, 2017

@Bargs

Bargs approved these changes Apr 28, 2017

Pending tests passing, LGTM

@lukasolson lukasolson merged commit 2e7b202 into elastic:master May 1, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@lukasolson lukasolson added v5.4.1 v5.5.0 v6.0.0 and removed v5.4.1 labels May 1, 2017

@lukasolson

This comment has been minimized.

Show comment
Hide comment
@lukasolson

lukasolson May 1, 2017

Member

Backported to 5.x (5.5.0) in 732ec35.
Backported to 5.4 (5.4.1) in 72443cd.

Member

lukasolson commented May 1, 2017

Backported to 5.x (5.5.0) in 732ec35.
Backported to 5.4 (5.4.1) in 72443cd.

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

@lukasolson lukasolson deleted the lukasolson:add-ignore_unmapped-geo-filters branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment