Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused title attribute from saved-object-finder. #11548

Merged

Conversation

Projects
None yet
2 participants
@cjcenizal
Copy link
Contributor

commented May 1, 2017

Addresses #11520.

Ensure img elements have alt text where necessary (none do).
- Add aria-hidden to global nav icon.

@cjcenizal cjcenizal force-pushed the cjcenizal:11520/improvement/accessibility-alt-text branch from c91abee to 9650afe May 1, 2017

@cjcenizal cjcenizal changed the title [WIP] Improve accessibility by adding alternative text for screen-readers. Improve accessibility by adding alternative text for screen-readers. May 3, 2017

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2017

jenkins, test this

@cjcenizal cjcenizal force-pushed the cjcenizal:11520/improvement/accessibility-alt-text branch from 732aee8 to 4bafa03 May 4, 2017

@@ -28,6 +27,10 @@
</div>

<div class="list-group-item list-group-item--noBorder" ng-switch-when="search">
<saved-object-finder title="Choose a search" type="searches" use-local-management="true" on-choose="opts.addSearch"></saved-object-finder>
<saved-object-finder
type="searches"

This comment has been minimized.

Copy link
@cjcenizal

cjcenizal May 4, 2017

Author Contributor

Looks like the title attribute isn't used, so I removed it.

<img
ng-if="icon"
class="global-nav-link__icon-image"
kbn-src="{{ '/' + icon }}"
alt=""
aria-hidden

This comment has been minimized.

Copy link
@cjcenizal

cjcenizal May 4, 2017

Author Contributor

This image means nothing to screen readers, so we hide it.

@kobelb

kobelb approved these changes May 8, 2017

Copy link
Contributor

left a comment

LGTM

@cjcenizal cjcenizal merged commit c1b714e into elastic:master May 11, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:11520/improvement/accessibility-alt-text branch May 11, 2017

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 11, 2017

Improve accessibility by adding alternative text for screen-readers. (e…
…lastic#11548)

* Ensure img elements have alt text where necessary (none do).
- Add aria-hidden to global nav icon.

* Remove unused title attribute from SavedObjectFinder.

cjcenizal added a commit that referenced this pull request May 11, 2017

Improve accessibility by adding alternative text for screen-readers. (#…
…11548) (#11745)

* Ensure img elements have alt text where necessary (none do).
- Add aria-hidden to global nav icon.

* Remove unused title attribute from SavedObjectFinder.

@cjcenizal cjcenizal changed the title Improve accessibility by adding alternative text for screen-readers. Remove unused title attribute from saved-object-finder. May 19, 2017

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

Improve accessibility by adding alternative text for screen-readers. (e…
…lastic#11548)

* Ensure img elements have alt text where necessary (none do).
- Add aria-hidden to global nav icon.

* Remove unused title attribute from SavedObjectFinder.

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Improve accessibility by adding alternative text for screen-readers. (e…
…lastic#11548) (elastic#11745)

* Ensure img elements have alt text where necessary (none do).
- Add aria-hidden to global nav icon.

* Remove unused title attribute from SavedObjectFinder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.