Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable save button if visualization is dirty #11576

Merged
merged 3 commits into from May 16, 2017

Conversation

Projects
None yet
6 participants
@scampi
Copy link
Contributor

commented May 2, 2017

close #11575

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2017

Can one of the admins verify this patch?

@scampi scampi changed the title disable save button if visualization is dirty [WIP] disable save button if visualization is dirty May 3, 2017

@scampi

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2017

I'm going to try to write a small test for this.

@scampi scampi changed the title [WIP] disable save button if visualization is dirty disable save button if visualization is dirty May 3, 2017

@scampi

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2017

PR is now ready for review.

@thomasneirynck thomasneirynck self-requested a review May 12, 2017

@thomasneirynck

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

hi @scampi, my apologies for the little delay on this one. I'll take a look later today. In the meantime, do you mind rebasing and resolve merge conflict when you get a chance? thx!

@thomasneirynck
Copy link
Contributor

left a comment

This is a very nice UX improvement. thx!

The merge conflict is pretty minor, some other methods were inserted at the same location in the UI-test helpers, so rebase should be pretty straightforward.

LGTM pending rebase.

@@ -25,6 +25,7 @@ export default function ({ getService, loadTestFile }) {
});
});

loadTestFile(require.resolve('./_editor'));

This comment has been minimized.

Copy link
@thomasneirynck

thomasneirynck May 12, 2017

Contributor

this is why you're awesome @scampi. Community PRs rarely include UI-tests!!!

@thomasneirynck thomasneirynck requested a review from ppisljar May 12, 2017

@thomasneirynck

This comment has been minimized.

Copy link
Contributor

commented May 12, 2017

@ppisljar you want to take 2nd look? thx

scampi added some commits May 2, 2017

@scampi scampi force-pushed the scampi:visualize-save branch from 2a47f0c to 803c804 May 12, 2017

@scampi

This comment has been minimized.

Copy link
Contributor Author

commented May 12, 2017

@thomasneirynck thanks for the kind words! I have rebased against master. I added a little 3rd commit so that the tests make more sense.

@ppisljar
Copy link
Member

left a comment

LGTM

@thomasneirynck thomasneirynck merged commit efc6218 into elastic:master May 16, 2017

1 check passed

CLA Commit author has signed the CLA
Details

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request May 16, 2017

disable save button if visualization is dirty (elastic#11576)
(backport: manual merge edits in test file)
@thomasneirynck

This comment has been minimized.

Copy link
Contributor

commented May 16, 2017

5.x backport: #11816

@scampi scampi deleted the scampi:visualize-save branch May 16, 2017

thomasneirynck added a commit that referenced this pull request May 16, 2017

disable save button if visualization is dirty (#11576) (#11816)
(backport: manual merge edits in test file)

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

@thomasneirynck

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2017

I'm going to revert this as it introduced two UX regressions (#12082). I missed those. I think this is a pretty good change still, but we'll need to look into two issues:

  • changing the time-filter should not cause the save-button to be disabled
  • disabling the save button prevents users from doing a save-to-rename operation

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jun 2, 2017

@epixa epixa added the v6.0.0-alpha2 label Jun 2, 2017

thomasneirynck added a commit that referenced this pull request Jun 12, 2017

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jun 12, 2017

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jun 12, 2017

thomasneirynck added a commit that referenced this pull request Jun 13, 2017

thomasneirynck added a commit that referenced this pull request Jun 13, 2017

chrisronline added a commit to chrisronline/kibana that referenced this pull request Jun 14, 2017

stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request Jun 14, 2017

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.