New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] Make CardGroup split apart by default. Add kuiCardGroup--united modifier. #11580

Merged
merged 1 commit into from May 3, 2017

Conversation

Projects
None yet
3 participants
@cjcenizal
Contributor

cjcenizal commented May 3, 2017

Addresses #11577 (comment)

image

Make CardGroup split apart by default. Add kuiCardGroup--united modif…
…ier.

- Also remove unused kuiNotice classes.
.kuiNoticeText {
font-size: $globalFontSize;
margin-bottom: 12px;
}

This comment has been minimized.

@cjcenizal

cjcenizal May 3, 2017

Contributor

I removed these styles which are no longer being used.

@cjcenizal

cjcenizal May 3, 2017

Contributor

I removed these styles which are no longer being used.

This comment has been minimized.

@ycombinator

ycombinator May 3, 2017

Contributor

I believe these are still being used in x-pack monitoring.

@ycombinator

ycombinator May 3, 2017

Contributor

I believe these are still being used in x-pack monitoring.

This comment has been minimized.

@cjcenizal

cjcenizal May 3, 2017

Contributor

Thanks man, I created a PR that removed them from Monitoring and cross-linked here.

@cjcenizal

cjcenizal May 3, 2017

Contributor

Thanks man, I created a PR that removed them from Monitoring and cross-linked here.

@ycombinator

Left a couple minor comments.

border-radius: 0;
}
.kuiCardGroup__card + .kuiCardGroup__card {

This comment has been minimized.

@ycombinator

ycombinator May 3, 2017

Contributor

Any reason not to move this inside of .kuiCardGroup__card and use & + & for consistency with how its being done for .kuiCardGroup .kuiCardGroup__card?

@ycombinator

ycombinator May 3, 2017

Contributor

Any reason not to move this inside of .kuiCardGroup__card and use & + & for consistency with how its being done for .kuiCardGroup .kuiCardGroup__card?

This comment has been minimized.

@cjcenizal

cjcenizal May 3, 2017

Contributor

The currently Sass results in this CSS:

.kuiCardGroup--united .kuiCardGroup__card + .kuiCardGroup__card

If I use & + & we end up with:

.kuiCardGroup--united .kuiCardGroup__card + .kuiCardGroup--united .kuiCardGroup__card

For some reason, the first selector correctly targets the right elements but the second one doesn't. I'm really not sure why!

@cjcenizal

cjcenizal May 3, 2017

Contributor

The currently Sass results in this CSS:

.kuiCardGroup--united .kuiCardGroup__card + .kuiCardGroup__card

If I use & + & we end up with:

.kuiCardGroup--united .kuiCardGroup__card + .kuiCardGroup--united .kuiCardGroup__card

For some reason, the first selector correctly targets the right elements but the second one doesn't. I'm really not sure why!

.kuiNoticeText {
font-size: $globalFontSize;
margin-bottom: 12px;
}

This comment has been minimized.

@ycombinator

ycombinator May 3, 2017

Contributor

I believe these are still being used in x-pack monitoring.

@ycombinator

ycombinator May 3, 2017

Contributor

I believe these are still being used in x-pack monitoring.

@ycombinator

LGTM!

@cjcenizal cjcenizal merged commit 114a014 into elastic:master May 3, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:11577/chore/kui-card-group branch May 3, 2017

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 3, 2017

cjcenizal added a commit that referenced this pull request May 3, 2017

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment