New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dashboard screen-reader accessibility. #11600

Merged
merged 3 commits into from May 5, 2017

Conversation

Projects
None yet
4 participants
@cjcenizal
Contributor

cjcenizal commented May 4, 2017

Partially addresses #11520. Extracts some work from #11548.

  • Add aria-label for Dashboard Add Panel tabs.
  • Add aria-label for Dashboard Panel title.
  • Refactor empty Dashboard prompt message to improve accessibility.
  • Adjust aria-labels for Dashboard query bar.
  • Adjust aria-labels for Dashboard Landing Page table.
  • Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.
Improve Dashboard screen-reader accessibility:
- Add aria-label for Dashboard Add Panel tabs.
- Add aria-label for Dashboard Panel title.
- Refactor empty Dashboard prompt message to improve accessibility.
- Adjust aria-labels for Dashboard query bar.
- Adjust aria-labels for Dashboard Landing Page table.
- Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.
<p class="kuiText kuiVerticalRhythm">
Click the <a class="kuiButton kuiButton--primary kuiButton--small" ng-click="kbnTopNav.open('add'); toggleAddVisualization = !toggleAddVisualization" aria-label="Add visualization">Add</a> button in the menu bar above to add a visualization to the dashboard. <br/>If you haven't set up any visualizations yet, <a class="kuiLink" href="#/visualize">visit the Visualize app</a> to create your first visualization.
</p>

This comment has been minimized.

@cjcenizal

cjcenizal May 4, 2017

Contributor

No real changes here, just used UI Framework classes.

@cjcenizal

cjcenizal May 4, 2017

Contributor

No real changes here, just used UI Framework classes.

<p class="kuiText kuiVerticalRhythm">
Click the <a class="kuiButton kuiButton--primary kuiButton--small" ng-click="kbnTopNav.click('edit');">Edit</a> button in the menu bar above to start working on your new dashboard.
</p>

This comment has been minimized.

@cjcenizal

cjcenizal May 4, 2017

Contributor

No real changes here, just used UI Framework classes.

@cjcenizal

cjcenizal May 4, 2017

Contributor

No real changes here, just used UI Framework classes.

@Stacey-Gammon

LGTM

@cjcenizal cjcenizal merged commit 16f55d1 into elastic:master May 5, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:11520/improvement/dashboard-screen-reader-accessibility branch May 5, 2017

cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 5, 2017

Improve Dashboard screen-reader accessibility. (elastic#11600)
* Improve Dashboard screen-reader accessibility:
- Add aria-label for Dashboard Add Panel tabs.
- Add aria-label for Dashboard Panel title.
- Refactor empty Dashboard prompt message to improve accessibility.
- Adjust aria-labels for Dashboard query bar.
- Adjust aria-labels for Dashboard Landing Page table.
- Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.

cjcenizal added a commit that referenced this pull request May 5, 2017

Improve Dashboard screen-reader accessibility. (#11600) (#11633)
* Improve Dashboard screen-reader accessibility:
- Add aria-label for Dashboard Add Panel tabs.
- Add aria-label for Dashboard Panel title.
- Refactor empty Dashboard prompt message to improve accessibility.
- Adjust aria-labels for Dashboard query bar.
- Adjust aria-labels for Dashboard Landing Page table.
- Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

Improve Dashboard screen-reader accessibility. (elastic#11600)
* Improve Dashboard screen-reader accessibility:
- Add aria-label for Dashboard Add Panel tabs.
- Add aria-label for Dashboard Panel title.
- Refactor empty Dashboard prompt message to improve accessibility.
- Adjust aria-labels for Dashboard query bar.
- Adjust aria-labels for Dashboard Landing Page table.
- Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Improve Dashboard screen-reader accessibility. (elastic#11600) (elast…
…ic#11633)

* Improve Dashboard screen-reader accessibility:
- Add aria-label for Dashboard Add Panel tabs.
- Add aria-label for Dashboard Panel title.
- Refactor empty Dashboard prompt message to improve accessibility.
- Adjust aria-labels for Dashboard query bar.
- Adjust aria-labels for Dashboard Landing Page table.
- Adjust aria-labels and interactive elements of Dashboard Panel actions buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment