Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix suggestions in Timelion Visualization. #11638
This fixes a bug introduced by #11285. When you create a Timelion visualization, suggestions weren't showing up. This PR fixes that, so now they show up again. Also, the suggestions were no longer clickable. This PR also fixes that.
As part of this solution, I refactored timelionExpressionInput to use ng-transclude to accept any type of form control.
the bug fix works (so the suggestions do show and i can click them), added some minor comments ...
and some more things i noticed, which are not related to this PR:
some general autosuggestion isues:
some issues with the multiline editor (not sure if related):