Improve accessibility of the Datepicker. #11753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kobelb @stacey-gammon Would you mind holding off on reviewing this? I just realized I should be using |
|
btw timepicker falls under discovery, but I'm happy to have Stacey and Brandon do our work for us :) |
|
@Bargs Hahaha thanks man, I realized after I tagged them that it was a Discovery thing but then I thought about how much time you put into reviewing the |
|
@cjcenizal just let us know when it's ready for review! |
|
@stacey-gammon @kobelb OK this is ready for your 👁 now. Thanks! |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 19, 2017
* Add aria-label and kbn-accessible-click to Local Nav menu buttons. * Make Share menu keyboard accessible. * Make datepicker and timepicker keyboard accessible. * Revert some kbn-accessible-click instances in favor of native button elements.
cjcenizal
added a commit
that referenced
this pull request
May 19, 2017
* Add aria-label and kbn-accessible-click to Local Nav menu buttons. * Make Share menu keyboard accessible. * Make datepicker and timepicker keyboard accessible. * Revert some kbn-accessible-click instances in favor of native button elements.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 24, 2017
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
* Add aria-label and kbn-accessible-click to Local Nav menu buttons. * Make Share menu keyboard accessible. * Make datepicker and timepicker keyboard accessible. * Revert some kbn-accessible-click instances in favor of native button elements.
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 2, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 2, 2017
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 9, 2017
nreese
added a commit
that referenced
this pull request
Jun 9, 2017
* quick panel moved to directive * move relative to directive * move absolute to directive * move stuff from timepicker directive to new directives * move timepicker to right with flexbox * remove left padding for kbn-timepicker-section * merge in timepicker.html changes from - Improve accessibility of the Datepicker. (#11753) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds (#1) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds, so the content doesn't jump around as you switch modes.. * Make kbn-timepicker-content responsive so that it stacks content on narrower screens. * Combine Relative input and select fields using kuiFieldGroup. * Make Timepicker submit button wider. * Align button on right. * migrate inputs from form-control to kui classes * update generated dist/ui_framework.css * fix broken tests * create kbn-timerpicker-nav-button class and update kbn-timepicker-section to make each column the same width
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Jun 14, 2017
* quick panel moved to directive * move relative to directive * move absolute to directive * move stuff from timepicker directive to new directives * move timepicker to right with flexbox * remove left padding for kbn-timepicker-section * merge in timepicker.html changes from - Improve accessibility of the Datepicker. (elastic#11753) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds (#1) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds, so the content doesn't jump around as you switch modes.. * Make kbn-timepicker-content responsive so that it stacks content on narrower screens. * Combine Relative input and select fields using kuiFieldGroup. * Make Timepicker submit button wider. * Align button on right. * migrate inputs from form-control to kui classes * update generated dist/ui_framework.css * fix broken tests * create kbn-timerpicker-nav-button class and update kbn-timepicker-section to make each column the same width
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 14, 2017
* quick panel moved to directive * move relative to directive * move absolute to directive * move stuff from timepicker directive to new directives * move timepicker to right with flexbox * remove left padding for kbn-timepicker-section * merge in timepicker.html changes from - Improve accessibility of the Datepicker. (elastic#11753) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds (#1) * Adjust markup and styles so that the Quick, Relative, and Absolute layouts all occupy the same bounds, so the content doesn't jump around as you switch modes.. * Make kbn-timepicker-content responsive so that it stacks content on narrower screens. * Combine Relative input and select fields using kuiFieldGroup. * Make Timepicker submit button wider. * Align button on right. * migrate inputs from form-control to kui classes * update generated dist/ui_framework.css * fix broken tests * create kbn-timerpicker-nav-button class and update kbn-timepicker-section to make each column the same width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11528 and partially addresses #11532.
This PR enables: