Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Improves Table UI (consistent dates) #117643

Merged
merged 8 commits into from Nov 9, 2021
Merged

[Security Solution][Detections] Improves Table UI (consistent dates) #117643

merged 8 commits into from Nov 9, 2021

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Nov 5, 2021 •
edited

Issue #117034

Summary

To make dates consistent across Security tables(Rules, Rules Monitoring, Exceptions) FormattedRelativePreferenceDate was reused with added additional capabilities: configurable relative threshold in hours(default into 1hr), tooltips anchor class and field name.

Rules Monitoring

Before

Screenshot 2021-11-05 at 13 06 53

#### After

Screenshot 2021-11-05 at 12 59 52

Rules

Before

Screenshot 2021-11-05 at 13 04 58

#### After

Screenshot 2021-11-05 at 12 37 15

Exceptions

Before

Screenshot 2021-11-05 at 13 05 27

#### After

Screenshot 2021-11-05 at 12 35 39

Tooltip example

Screenshot 2021-11-09 at 11 34 45

Checklist

Delete any items that are not applicable to this PR.

@vitaliidm vitaliidm changed the title [Security Solution][Detections] Table UI: consistent dates [Security Solution][Detections] Improves Table UI (consistent dates) Nov 5, 2021
@vitaliidm vitaliidm added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team labels Nov 5, 2021
@vitaliidm vitaliidm marked this pull request as ready for review November 5, 2021 16:48
@vitaliidm vitaliidm requested a review from a team as a code owner November 5, 2021 16:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added v8.0.0 v8.1.0 Feature:Rule Exceptions Security Solution Rule Exceptions feature Feature:Rule Management Security Solution Detection Rule Management Feature:Rule Monitoring Security Solution Detection Rule Monitoring enhancement New value added to drive a business result auto-backport Deprecated: Automatically backport this PR after it's merged labels Nov 8, 2021
@banderror banderror requested a review from a team November 8, 2021 11:39
@banderror
Copy link
Contributor

@elasticmachine merge upstream

@vitaliidm
Copy link
Contributor Author

@elasticmachine merge upstream

xcrzx
xcrzx approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@xcrzx xcrzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the changes, Vitalii 👍

@vitaliidm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default Firefox Tests / Spaces app Enter Space allows user to navigate to different spaces, respecting the configured default route

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.5MB 4.5MB +385.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 254.5KB 254.5KB +43.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit d1d5e79 into elastic:main Nov 9, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 9, 2021
@vitaliidm @kibanamachine
[Security Solution][Detections] Improves Table UI (consistent dates) (e…
9564fff 
…lastic#117643)

[Security Solution][Detections] Improves Table UI (consistent dates) (elastic#117643)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Nov 9, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 9, 2021
@kibanamachine @vitaliidm
[Security Solution][Detections] Improves Table UI (consistent dates) (#…
058f7f1 
…117643) (#118084)

[Security Solution][Detections] Improves Table UI (consistent dates) (#117643)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Nov 10, 2021
@vitaliidm @kibanamachine @kpatticha
[Security Solution][Detections] Improves Table UI (consistent dates) (e…
1f022e8 
…lastic#117643)

[Security Solution][Detections] Improves Table UI (consistent dates) (elastic#117643)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@vitaliidm vitaliidm deleted the security-solution/detection-rules-table-dates-alignments branch November 10, 2021 10:19
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
@vitaliidm @kibanamachine @fkanout
[Security Solution][Detections] Improves Table UI (consistent dates) (e…
0013003 
…lastic#117643)

[Security Solution][Detections] Improves Table UI (consistent dates) (elastic#117643)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@banderror banderror linked an issue Nov 19, 2021 that may be closed by this pull request
[Security Solution][Detections] Table UI: consistent dates #117034
Closed
3 tasks
@banderror banderror mentioned this pull request Nov 19, 2021
Closed
3 tasks
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
@vitaliidm @kibanamachine
[Security Solution][Detections] Improves Table UI (consistent dates) (e…
13d1063 
…lastic#117643)

[Security Solution][Detections] Improves Table UI (consistent dates) (elastic#117643)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xcrzx xcrzx xcrzx approved these changes

Assignees

@vitaliidm vitaliidm

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged enhancement New value added to drive a business result Feature:Rule Exceptions Security Solution Rule Exceptions feature Feature:Rule Management Security Solution Detection Rule Management Feature:Rule Monitoring Security Solution Detection Rule Monitoring release_note:enhancement Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution][Detections] Table UI: consistent dates
5 participants
@vitaliidm @elasticmachine @banderror @kibanamachine @xcrzx