Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use day, month, year provided by datepicker #11773

Merged
merged 2 commits into from May 17, 2017

Conversation

Projects
None yet
4 participants
@Bargs
Copy link
Contributor

commented May 12, 2017

Fixes #5370

The datepicker directive uses native Javascript Dates, ignoring moment's default timezone. This causes the datepicker and the text input above it to get out of sync if the user changed the dateFormat:tz config in advanced settings. The text input will show the date in the user selected timezone, the datepicker will show the date in the local browser timezone. Since we really just want a day, month, year from the datepicker instead of a moment in time, we grab those individual values from the native date.

@jbudz

jbudz approved these changes May 15, 2017

@lukasolson lukasolson self-assigned this May 15, 2017

@lukasolson
Copy link
Member

left a comment

Behavior and code change LGTM, but can you add a corresponding test for it?

Bargs added some commits May 12, 2017

@Bargs Bargs force-pushed the Bargs:fixTimepicker branch from 1a18271 to 1f3de2d May 15, 2017

@Bargs

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2017

@lukasolson test added

@lukasolson
Copy link
Member

left a comment

LGTM

@epixa epixa added the v6.0.0-alpha2 label May 17, 2017

@Bargs Bargs merged commit 39eb457 into elastic:master May 17, 2017

2 checks passed

CLA Commit author is a member of Elasticsearch
Details
kibana-ci Build finished.
Details

Bargs added a commit to Bargs/kibana that referenced this pull request May 17, 2017

Only use day, month, year provided by datepicker (elastic#11773)
* Only use day, month, year provided by datepicker instead of moment in time

Bargs added a commit to Bargs/kibana that referenced this pull request May 17, 2017

Only use day, month, year provided by datepicker (elastic#11773)
* Only use day, month, year provided by datepicker instead of moment in time

Bargs added a commit that referenced this pull request May 18, 2017

Only use day, month, year provided by datepicker (#11773) (#11882)
* Only use day, month, year provided by datepicker instead of moment in time

Bargs added a commit that referenced this pull request May 18, 2017

Only use day, month, year provided by datepicker (#11773) (#11883)
* Only use day, month, year provided by datepicker instead of moment in time

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

Only use day, month, year provided by datepicker (elastic#11773)
* Only use day, month, year provided by datepicker instead of moment in time

Dreadnoth added a commit to Dreadnoth/kibana that referenced this pull request Aug 8, 2017

Only use day, month, year provided by datepicker (elastic#11773) (ela…
…stic#11882)

* Only use day, month, year provided by datepicker instead of moment in time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.