Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Getting Started page (#11673)" #11788

Merged
merged 1 commit into from
May 15, 2017

Conversation

epixa
Copy link
Contributor

@epixa epixa commented May 15, 2017

This reverts commit 211b3d4.

This was breaking builds, so we revert until we figure out why.

This reverts commit 211b3d4.

This was breaking builds, so we revert until we figure out why.
@epixa
Copy link
Contributor Author

epixa commented May 15, 2017

This isn't necessary if #11789 goes green

@ycombinator
Copy link
Contributor

#11789 isn't going to go green because it is reporting this failure in https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/4543/consoleFull:

 └-: console app
   └-> "before all" hook
   └-: console app
     └-> "before all" hook
       │ debg  navigateTo console
       │ debg  Clicking opt-out link
       │ debg  in findTestSubject: [data-test-subj~="lnkGettingStartedOptOut"]
     └- ✖ fail: "console app console app "before all" hook"
     │        Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

This PR, however, is green so I say we merge this PR for now. I'll amend #11789 to include 211b3d4 and keep working on getting it green.

@epixa epixa merged commit b09d131 into elastic:master May 15, 2017
epixa added a commit that referenced this pull request May 15, 2017
This reverts commit 211b3d4.

This was breaking builds, so we revert until we figure out why.
@epixa
Copy link
Contributor Author

epixa commented May 15, 2017

5.x c6baef8

snide pushed a commit to snide/kibana that referenced this pull request May 30, 2017
This reverts commit 211b3d4.

This was breaking builds, so we revert until we figure out why.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants