Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Index pattern creation] Move the error message to below the input field #11801

Conversation

Projects
None yet
4 participants
@chrisronline
Copy link
Contributor

commented May 15, 2017

Closes #11410

Summary

This PR makes a small change to the index pattern creation page by surfacing index-related errors directly underneath the input field, rather than on the Create button. This helps visually connect the error with the state causing the error. It's important to note that the Create button will continue to be disabled in this error state, just as before.

If it's not obvious, the new UI is based off the StatusText UI component

Screenshots

New Error Surfacing

screen shot 2017-05-15 at 3 09 22 pm

Old Error Surfacing

screen shot 2017-05-15 at 3 08 50 pm

@ycombinator
Copy link
Contributor

left a comment

Functionality LGTM. Left a minor comment on the code.

@@ -44,6 +44,16 @@
>
</div>

<!-- Input error text -->
<div class="kuiVerticalRhythm" ng-if="controller.fetchFieldsError">

This comment has been minimized.

Copy link
@ycombinator

ycombinator May 16, 2017

Contributor

Per our HTML styleguide we break up tags with multiple attributes onto multiple lines, so its more readable + easy to see attribute adds/removes later.

This comment has been minimized.

Copy link
@chrisronline

chrisronline May 16, 2017

Author Contributor

Np, good to know. I'll fix it up

@ycombinator
Copy link
Contributor

left a comment

LGTM!

@BigFunger
Copy link
Contributor

left a comment

LGTM!

@chrisronline chrisronline merged commit c2319d5 into elastic:master May 16, 2017

1 check passed

kibana-ci Build finished.
Details

chrisronline added a commit that referenced this pull request May 16, 2017

[Index pattern creation] Move the error message to below the input fi…
…eld (#11801)

* Move the error message to below the input field, resolves #11410

* Update to match HTML styleguide
@chrisronline

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2017

Backport

5.x: 09d97ba

@chrisronline chrisronline deleted the chrisronline:enhancement/index-pattern-error-surfacing branch May 16, 2017

@spalger spalger added v5.4.1 v5.5.0 and removed v5.4.0 v5.4.1 labels May 16, 2017

@spalger

This comment has been minimized.

Copy link
Member

commented May 16, 2017

@chrisronline the 5.x branch is for the upcomming 5.5 release, if you really want this to go out with 5.4.1 (should we ship it) it would need to be backported to the 5.4 branch as well.

@chrisronline

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2017

@spalger Yup! It's an enhancement so I don't think we need it in 5.4.x, plus the directory structure changed quite a bit from 5.4 -> 5.5 so a potentially painful backport combined with not really needing to backport enhancements resulted in me just putting in 5.x for the next minor bump off 5.

EDIT: and I see the confusion. I should have removed the 5.4.0 label once I realized it wasn't going in. My bad and thanks for double checking this

snide added a commit to snide/kibana that referenced this pull request May 30, 2017

[Index pattern creation] Move the error message to below the input fi…
…eld (elastic#11801)

* Move the error message to below the input field, resolves elastic#11410

* Update to match HTML styleguide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.