Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization legend tooltip - remove animation #11910

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@nreese
Copy link
Contributor

commented May 18, 2017

Fixes #11641

Visualization legend tooltips are implemented via the angular-bootstrap tooltip Attribute directive. The tooltip fades in and out by default. The fade-out animation causes problems because the legend items are so closely placed together. When moving the mouse down to the next legend item, the mouseenter and mouseleave events get messed up by trigging on the fading-out tooltip instead of the next legend item. Setting the animation to false removes the possibility of unintentional mouseenter and mouseleave events. This makes the UI feel snappier and more consistent since the chart tooltips do not have any animation as well.

before
before

after
after

@nreese nreese requested a review from stacey-gammon May 18, 2017

@stacey-gammon
Copy link
Contributor

left a comment

Awesome! 👏

@nreese nreese merged commit b5c51d1 into elastic:master May 19, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details
@Funbit

This comment has been minimized.

Copy link

commented May 19, 2017

Yay! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.