Detect cookies on login page #120944

thomheymann · 2021-12-09T16:29:55Z

Resolves #97200

This PR fixes a bug caused by Safari's "Prevent cross-site tracking" feature.

When this feature is enabled Safari prevents us from setting cookies when embedded inside an iframe.

There's no workaround for this behaviour but we can provide a better user experience by allowing users to open the embedded content inside a new window where they can log in without any issues.

When Kibana can't set cookies and is embedded in an iframe

When Kibana can't set cookies and is not embedded in an iframe

Testing

Run yarn es snapshot --license trial --ssl
Run yarn start --ssl
Add sample data
View a dashboard and generate embed code
Got to https://jsfiddle.net and paste embed code to view Kibana inside iframe

elasticmachine · 2021-12-09T16:29:58Z

Pinging @elastic/kibana-security (Team:Security)

thomheymann · 2021-12-10T11:51:45Z

@elasticmachine merge upstream

thomheymann · 2021-12-13T11:31:59Z

@elasticmachine merge upstream

azasypkin · 2021-12-13T12:13:30Z

ACK: will review today or tomorrow.

azasypkin

Looks great! Just left two questions.

x-pack/plugins/security/public/authentication/login/login_page.tsx

x-pack/plugins/security/public/authentication/login/login_page.test.tsx

x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap

x-pack/plugins/security/public/authentication/login/login_page.tsx

….tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

…s__/login_page.test.tsx.snap Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

jportner

Thanks for making this change, I think the different wording will help us troubleshoot SDH issues more quickly, as this has been a problem in the past.

Code review only -- LGTM on green CI, will leave final approval to Oleg

jportner · 2021-12-16T04:16:49Z

x-pack/plugins/security/public/authentication/login/login_page.tsx

+                {this.props.sameSiteCookies !== 'None' ? (
+                  <FormattedMessage
+                    id="xpack.security.loginPage.openInNewWindowOrChangeKibanaConfigTitle"
+                    defaultMessage="To view this content, open it in a new window or ask your administrator to allow cross-origin cookies."
+                  />
+                ) : (
+                  <FormattedMessage
+                    id="xpack.security.loginPage.openInNewWindowOrChangeBrowserSettingsTitle"
+                    defaultMessage="To view this content, open it in a new window or adjust your browser settings to allow third-party cookies."
+                  />
+                )}


azasypkin · 2021-12-16T10:32:23Z

ACK: reviewing...

azasypkin

Looks great, thanks for making these changes!

x-pack/plugins/security/public/authentication/login/login_page.tsx

kibana-ci · 2021-12-16T12:46:08Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`security`	491.6KB	493.0KB	+1.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`security`	50.1KB	50.1KB	+34.0B

History

💚 Build #13592 succeeded 72c9af7
💔 Build #13555 failed b8a4561
💔 Build #13552 failed d0c3ac4
💚 Build #13538 succeeded e5023d5
💔 Build #13517 failed 6215e6e
💔 Build #13365 failed 48d0175

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-12-16T13:21:28Z

💔 Backport failed

Status	Branch	Result
❌	8.0	Commit could not be cherrypicked due to conflicts
❌	7.17	The branch "7.17" is invalid or doesn't exist

To backport manually run:
node scripts/backport --pr 120944

kibanamachine · 2021-12-20T13:24:59Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120944 or prevent reminders by adding the backport:skip label.

kibanamachine · 2021-12-21T13:34:58Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 120944 or prevent reminders by adding the backport:skip label.

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

Detect cookies in login page

b2f1d7a

thomheymann added release_note:fix Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 auto-backport Deprecated: Automatically backport this PR after it's merged v8.1.0 v7.17.0 labels Dec 9, 2021

thomheymann requested a review from a team December 9, 2021 16:29

legrego added the ci:deploy-cloud label Dec 9, 2021

thomheymann added 2 commits December 9, 2021 18:20

Fix i18n messages

6ce3fbd

Update snapshots

15ecd69

Merge branch 'main' into detect-cookies

9c82513

Merge branch 'main' into detect-cookies

670b7cf

azasypkin self-requested a review December 13, 2021 12:13

azasypkin reviewed Dec 14, 2021

View reviewed changes

Rename unit test

187a292

thomheymann requested a review from azasypkin December 14, 2021 12:13

thomheymann mentioned this pull request Dec 14, 2021

Fail gracefully when cookies are disabled #121189

Open

Tweak copy

48d0175

gchaps reviewed Dec 15, 2021

View reviewed changes

x-pack/plugins/security/public/authentication/login/__snapshots__/login_page.test.tsx.snap Outdated Show resolved Hide resolved

x-pack/plugins/security/public/authentication/login/login_page.tsx Outdated Show resolved Hide resolved

thomheymann and others added 6 commits December 15, 2021 19:49

Update x-pack/plugins/security/public/authentication/login/login_page…

0e51eeb

….tsx Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update x-pack/plugins/security/public/authentication/login/__snapshot…

6215e6e

…s__/login_page.test.tsx.snap Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Update snapshots

6e804b4

Merge branch 'main' of github.com:elastic/kibana into detect-cookies

e5023d5

Add cross-origin cookie check

d0c3ac4

Remove console log

b8a4561

thomheymann requested a review from jportner December 15, 2021 23:01

jportner reviewed Dec 16, 2021

View reviewed changes

Fix types

72c9af7

azasypkin approved these changes Dec 16, 2021

View reviewed changes

x-pack/plugins/security/public/authentication/login/login_page.tsx Outdated Show resolved Hide resolved

thomheymann added 2 commits December 16, 2021 11:20

Fix typo

01fee86

Merge branch 'main' of github.com:elastic/kibana into detect-cookies

5a89f01

thomheymann merged commit e0eaca4 into elastic:main Dec 16, 2021

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 20, 2021

thomheymann mentioned this pull request Dec 21, 2021

[8.0] Detect cookies on login page (#120944) #121784

Merged

thomheymann added a commit to thomheymann/kibana that referenced this pull request Dec 21, 2021

Detect cookies on login page (elastic#120944)

f34947b

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

thomheymann mentioned this pull request Dec 21, 2021

[7.16] Detect cookies on login page (#120944) #121786

Merged

thomheymann added a commit that referenced this pull request Dec 21, 2021

Detect cookies on login page (#120944) (#121784)

667de29

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 21, 2021

thomheymann added a commit that referenced this pull request Dec 21, 2021

Detect cookies on login page (#120944) (#121786)

6fa971f

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021

Detect cookies on login page (elastic#120944)

ed907b0

thomheymann added a commit to thomheymann/kibana that referenced this pull request Dec 29, 2021

Detect cookies on login page (elastic#120944)

9474e91

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

thomheymann mentioned this pull request Dec 29, 2021

[7.17] Detect cookies on login page (#120944) #122115

Merged

thomheymann added a commit that referenced this pull request Dec 29, 2021

Detect cookies on login page (#120944) (#122115)

0b72ee9

# Conflicts: # x-pack/plugins/security/public/authentication/login/login_app.ts

gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022

Detect cookies on login page (elastic#120944)

4ed9736

legrego mentioned this pull request Jan 24, 2022

Add visibility options to embed code generator #100651

Open

tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect cookies on login page #120944

Detect cookies on login page #120944

thomheymann commented Dec 9, 2021 •

edited

elasticmachine commented Dec 9, 2021

thomheymann commented Dec 10, 2021

thomheymann commented Dec 13, 2021

azasypkin commented Dec 13, 2021

azasypkin left a comment

jportner left a comment

jportner Dec 16, 2021

azasypkin commented Dec 16, 2021

azasypkin left a comment

kibana-ci commented Dec 16, 2021

kibanamachine commented Dec 16, 2021

kibanamachine commented Dec 20, 2021

kibanamachine commented Dec 21, 2021

Navigation Menu

Detect cookies on login page #120944

Detect cookies on login page #120944

Conversation

thomheymann commented Dec 9, 2021 • edited

When Kibana can't set cookies and is embedded in an iframe

When Kibana can't set cookies and is not embedded in an iframe

Testing

elasticmachine commented Dec 9, 2021

thomheymann commented Dec 10, 2021

thomheymann commented Dec 13, 2021

azasypkin commented Dec 13, 2021

azasypkin left a comment

Choose a reason for hiding this comment

jportner left a comment

Choose a reason for hiding this comment

jportner Dec 16, 2021

Choose a reason for hiding this comment

azasypkin commented Dec 16, 2021

azasypkin left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 16, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Dec 16, 2021

💔 Backport failed

kibanamachine commented Dec 20, 2021

kibanamachine commented Dec 21, 2021

thomheymann commented Dec 9, 2021 •

edited