Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Framework] Allow kuiLocalNavRow to expand vertically if the content wraps. #12606

Conversation

Projects
None yet
4 participants
@cjcenizal
Copy link
Contributor

commented Jun 30, 2017

Addresses #12587

Implemented @snide's suggestion. This is less than ideal but it does solve the problem. I think we can address our breadcrumbs in a separate PR, since their wrapping behavior has been a long-standing issue.

image

@snide

snide approved these changes Jun 30, 2017

Copy link
Contributor

left a comment

Works for now as a quick fix that's similar to the previous functionality. 👍

@bhavyarm
Copy link
Contributor

left a comment

LGTM

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2017

jenkins, test this

@cjcenizal cjcenizal merged commit 189747a into elastic:master Jun 30, 2017

2 checks passed

CLA Commit author has signed the CLA
Details
kibana-ci Build finished.
Details

@cjcenizal cjcenizal deleted the cjcenizal:12587/bug/expand-local-nav-for-wrapping-content branch Jun 30, 2017

@epixa epixa added the v5.6.0 label Jun 30, 2017

@epixa

This comment has been minimized.

Copy link
Member

commented Jun 30, 2017

@cjcenizal This should go into 5.x as well, right? I added the label, but feel free to remove it if I'm missing something obvious

@cjcenizal

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2017

@epixa Yep 5.6 belongs in there too. Thanks for catching that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.